Merge pull request #8116 from michaelchadwick/remove-unneeded-ilios-c…

…ommon-slices

Remove unneeded ilios common slices

packages/ilios-common/addon/classes/events-base.js

@@ -40,7 +40,7 @@ export default class EventsBase extends Service {
     const sessionTerms = await session.get('terms');
     const course = await session.get('course');
     const courseTerms = await course.get('terms');
-    return uniqueValues(mapBy([...sessionTerms.slice(), ...courseTerms.slice()], 'id'));
+    return uniqueValues(mapBy([...sessionTerms, ...courseTerms], 'id'));
   }
 
   /**
@@ -86,7 +86,7 @@ export default class EventsBase extends Service {
   async getCohortIdsForEvent(event) {
     const course = await this.getCourseForEvent(event);
     const cohorts = await course.get('cohorts');
-    return mapBy(cohorts.slice(), 'id');
+    return mapBy(cohorts, 'id');
   }
 
   /**

packages/ilios-common/addon/components/course/collapsed-objectives.js

@@ -10,7 +10,7 @@ export default class CourseCollapsedObjectivesComponent extends Component {
   });
 
   get objectives() {
-    return this.objectivesRelationship ? this.objectivesRelationship.slice() : [];
+    return this.objectivesRelationship ? this.objectivesRelationship : [];
   }
 
   get objectivesWithParents() {

packages/ilios-common/addon/components/course/objective-list-item.js

@@ -67,22 +67,21 @@ export default class CourseObjectiveListItemComponent extends Component {
       return [...set, ...cohortObjectives.flat()];
     }, []);
     const parents = await this.args.courseObjective.programYearObjectives;
-    this.parentsBuffer = parents.slice().map((objective) => {
+    this.parentsBuffer = parents.map((objective) => {
       return findById(objectives, objective.id);
     });
     this.isManagingParents = true;
   });
 
   manageDescriptors = dropTask(async () => {
-    const meshDescriptors = await this.args.courseObjective.meshDescriptors;
-    this.descriptorsBuffer = meshDescriptors.slice();
+    this.descriptorsBuffer = await this.args.courseObjective.meshDescriptors;
     this.isManagingDescriptors = true;
   });
 
   manageTerms = dropTask(async (vocabulary) => {
     this.selectedVocabulary = vocabulary;
     const terms = await this.args.courseObjective.terms;
-    this.termsBuffer = terms.slice();
+    this.termsBuffer = terms;
     this.isManagingTerms = true;
   });
 

packages/ilios-common/addon/components/course/objective-list.js

@@ -40,7 +40,7 @@ export default class CourseObjectiveListComponent extends Component {
 
   get courseCohorts() {
     if (this.load.lastSuccessful && this.courseCohortsAsync) {
-      return this.courseCohortsAsync.slice();
+      return this.courseCohortsAsync;
     }
 
     return [];
@@ -81,7 +81,7 @@ export default class CourseObjectiveListComponent extends Component {
         'allowMultipleCourseObjectiveParents',
       );
       const objectives = await programYear.programYearObjectives;
-      const objectiveObjects = await map(objectives.slice(), async (objective) => {
+      const objectiveObjects = await map(objectives, async (objective) => {
         let competencyId = 0;
         let competencyTitle = intl.t('general.noAssociatedCompetency');
         let competencyParent = null;

packages/ilios-common/addon/components/course/visualize-instructor-session-type-graph.js

@@ -74,7 +74,7 @@ export default class CourseVisualizeInstructorSessionTypeGraph extends Component
       return mapBy(allInstructors, 'id').includes(user.id);
     });
 
-    const sessionsWithSessionType = await map(sessionsWithUser.slice(), async (session) => {
+    const sessionsWithSessionType = await map(sessionsWithUser, async (session) => {
       const sessionType = await session.sessionType;
       return {
         session,

packages/ilios-common/addon/components/course/visualize-instructor.js

@@ -23,7 +23,7 @@ export default class CourseVisualizeInstructorComponent extends Component {
   }
 
   get sessions() {
-    return this.sessionsData.isResolved ? this.sessionsData.value.slice() : [];
+    return this.sessionsData.isResolved ? this.sessionsData.value : [];
   }
 
   @cached

packages/ilios-common/addon/components/course/visualize-objectives-graph.js

@@ -91,7 +91,7 @@ export default class CourseVisualizeObjectivesGraph extends Component {
       async ({ session, minutes }) => {
         const sessionObjectives = await session.sessionObjectives;
         const sessionObjectivesWithParents = await filter(
-          sessionObjectives.slice(),
+          sessionObjectives,
           async (sessionObjective) => {
             const parents = await sessionObjective.courseObjectives;
             return parents.length;
@@ -101,7 +101,7 @@ export default class CourseVisualizeObjectivesGraph extends Component {
           sessionObjectivesWithParents,
           async (sessionObjective) => {
             const parents = await sessionObjective.courseObjectives;
-            return mapBy(parents.slice(), 'id');
+            return mapBy(parents, 'id');
           },
         );
         const flatObjectives = courseSessionObjectives.reduce((flattened, arr) => {
@@ -119,8 +119,8 @@ export default class CourseVisualizeObjectivesGraph extends Component {
 
     // condensed objectives map
     const courseObjectives = await this.args.course.courseObjectives;
-    const mappedObjectives = await map(courseObjectives.slice(), async (courseObjective) => {
-      const programYearObjectives = (await courseObjective.programYearObjectives).slice();
+    const mappedObjectives = await map(courseObjectives, async (courseObjective) => {
+      const programYearObjectives = await courseObjective.programYearObjectives;
       const competencyTitles = (
         await map(programYearObjectives, async (pyObjective) => {
           const competency = await pyObjective.competency;

packages/ilios-common/addon/components/course/visualize-vocabulary-graph.js

@@ -80,7 +80,7 @@ export default class CourseVisualizeVocabularyGraph extends Component {
       sessionsWithMinutes,
       async ({ session, minutes }) => {
         const sessionTerms = await session.terms;
-        const sessionTermsInThisVocabulary = await filter(sessionTerms.slice(), async (term) => {
+        const sessionTermsInThisVocabulary = await filter(sessionTerms, async (term) => {
           const termVocab = await term.vocabulary;
           return termVocab.id === this.args.vocabulary.id;
         });

packages/ilios-common/addon/components/dashboard/calendar-filters.js

@@ -38,13 +38,13 @@ export default class DashboardCalendarFiltersComponent extends Component {
   async loadSessionTypes(school) {
     await this.dataLoader.loadSchoolForCalendar(school.id);
     const types = await school.sessionTypes;
-    return sortBy(types.slice(), 'title');
+    return sortBy(types, 'title');
   }
 
   async loadVocabularies(school) {
     await this.dataLoader.loadSchoolForCalendar(school.id);
     const vocabularies = await school.vocabularies;
     await Promise.all(mapBy(vocabularies, 'terms'));
-    return sortBy(vocabularies.slice(), 'title');
+    return sortBy(vocabularies, 'title');
   }
 }

packages/ilios-common/addon/components/dashboard/calendar.js

@@ -160,9 +160,9 @@ export default class DashboardCalendarComponent extends Component {
   async getSchoolCohorts(school) {
     await this.dataLoader.loadSchoolForCalendar(school.id);
     const programs = await school.programs;
-    const programYears = await map(programs.slice(), async (program) => {
+    const programYears = await map(programs, async (program) => {
       const programYears = await program.programYears;
-      return programYears.slice();
+      return programYears;
     });
     const cohorts = await Promise.all(mapBy(programYears.flat(), 'cohort'));
     return cohorts.filter(Boolean);

packages/ilios-common/addon/components/dashboard/courses-calendar-filter.js

@@ -43,7 +43,7 @@ export default class DashboardCoursesCalendarFilterComponent extends Component {
   }
 
   get courses() {
-    return this.coursesRelationship ? this.coursesRelationship.slice() : [];
+    return this.coursesRelationship ? this.coursesRelationship : [];
   }
 
   get courseYears() {

packages/ilios-common/addon/components/dashboard/selected-term-tree.js

@@ -9,7 +9,7 @@ export default class DashboardSelectedTermTreeComponent extends Component {
   }
 
   get children() {
-    return this.childrenData.isResolved ? this.childrenData.value.slice() : [];
+    return this.childrenData.isResolved ? this.childrenData.value : [];
   }
 
   get level() {

packages/ilios-common/addon/components/detail-cohort-list.js

@@ -14,7 +14,7 @@ export default class DetailCohortListComponent extends Component {
       return false;
     }
 
-    const sortProxies = await map(cohorts.slice(), async (cohort) => {
+    const sortProxies = await map(cohorts, async (cohort) => {
       const programYear = await cohort.programYear;
       const program = await programYear.program;
       const school = await program.school;

packages/ilios-common/addon/components/detail-cohort-manager.js

@@ -79,7 +79,7 @@ export default class DetailCohortManagerComponent extends Component {
   async loadCohorts(course) {
     const school = await course.school;
     const allCohorts = await this.store.findAll('cohort');
-    const cohortProxies = await map(allCohorts.slice(), async (cohort) => {
+    const cohortProxies = await map(allCohorts, async (cohort) => {
       const programYear = await cohort.programYear;
       const program = await programYear.program;
       const school = await program.school;

packages/ilios-common/addon/components/detail-cohorts.js

@@ -20,7 +20,7 @@ export default class DetailCohortsComponent extends Component {
 
   manage = dropTask(async () => {
     const cohorts = await this.args.course.cohorts;
-    this.bufferedCohorts = [...cohorts.slice()];
+    this.bufferedCohorts = [...cohorts];
     this.isManaging = true;
   });
 

packages/ilios-common/addon/components/detail-instructors.js

@@ -58,8 +58,8 @@ export default class DetailInstructorsComponent extends Component {
       instructors: ilmSession.instructors,
     });
 
-    this.instructorGroupBuffer = instructorGroups.slice();
-    this.instructorBuffer = instructors.slice();
+    this.instructorGroupBuffer = instructorGroups;
+    this.instructorBuffer = instructors;
     this.isManaging = true;
   });
 
@@ -82,14 +82,14 @@ export default class DetailInstructorsComponent extends Component {
     if (!this.ilmInstructors) {
       return [];
     }
-    return this.ilmInstructors.slice();
+    return this.ilmInstructors;
   }
 
   get selectedIlmInstructorGroups() {
     if (!this.ilmInstructorGroups) {
       return [];
     }
-    return this.ilmInstructorGroups.slice();
+    return this.ilmInstructorGroups;
   }
 
   get instructorGroupCount() {

packages/ilios-common/addon/components/detail-learnergroups-list.js

@@ -27,12 +27,12 @@ export default class DetailLearnerGroupsListComponent extends Component {
       return [];
     }
     const cohorts = uniqueValues(
-      await map(this.args.learnerGroups.slice(), async (learnerGroup) => {
+      await map(this.args.learnerGroups, async (learnerGroup) => {
         return learnerGroup.cohort;
       }),
     );
     return map(cohorts, async (cohort) => {
-      const groups = await filter(this.args.learnerGroups.slice(), async (group) => {
+      const groups = await filter(this.args.learnerGroups, async (group) => {
         const groupCohort = await group.cohort;
         return groupCohort === cohort;
       });

packages/ilios-common/addon/components/detail-learners-and-learner-groups.js

@@ -65,8 +65,8 @@ export default class DetailLearnersAndLearnerGroupsComponent extends Component {
       learners: ilmSession.learners,
     });
 
-    this.learnerGroupBuffer = learnerGroups.slice();
-    this.learnerBuffer = learners.slice();
+    this.learnerGroupBuffer = learnerGroups;
+    this.learnerBuffer = learners;
     this.isManaging = true;
   });
 
@@ -96,14 +96,14 @@ export default class DetailLearnersAndLearnerGroupsComponent extends Component {
     if (!this.ilmLearners) {
       return [];
     }
-    return this.ilmLearners.slice();
+    return this.ilmLearners;
   }
 
   get selectedIlmLearnerGroups() {
     if (!this.ilmLearnerGroups) {
       return [];
     }
-    return this.ilmLearnerGroups.slice();
+    return this.ilmLearnerGroups;
   }
 
   @action

packages/ilios-common/addon/components/detail-learning-materials-item.js

@@ -21,7 +21,7 @@ export default class DetailLearningMaterialsItemComponent extends Component {
   }
 
   get meshDescriptors() {
-    return this.meshDescriptorsData.isResolved ? this.meshDescriptorsData.value.slice() : [];
+    return this.meshDescriptorsData.isResolved ? this.meshDescriptorsData.value : [];
   }
 
   get meshDescriptorsLoaded() {

packages/ilios-common/addon/components/detail-learning-materials.js

@@ -30,8 +30,8 @@ export default class DetailCohortsComponent extends Component {
 
   constructor() {
     super(...arguments);
-    this.learningMaterialStatuses = this.store.peekAll('learning-material-status').slice();
-    this.learningMaterialUserRoles = this.store.peekAll('learning-material-user-role').slice();
+    this.learningMaterialStatuses = this.store.peekAll('learning-material-status');
+    this.learningMaterialUserRoles = this.store.peekAll('learning-material-user-role');
   }
 
   @cached

packages/ilios-common/addon/components/detail-mesh.js

@@ -21,7 +21,7 @@ export default class DetailMeshComponent extends Component {
       return [];
     }
 
-    return this.meshDescriptorRelationship.slice();
+    return this.meshDescriptorRelationship;
   }
   @action
   manage() {

packages/ilios-common/addon/components/detail-taxonomies.js

@@ -29,7 +29,7 @@ export default class DetailTaxonomiesComponent extends Component {
   manage = dropTask(async () => {
     this.args.expand();
     const terms = await this.args.subject.terms;
-    this.bufferedTerms = [...terms.slice()];
+    this.bufferedTerms = [...terms];
     this.isManaging = true;
   });
 

packages/ilios-common/addon/components/learningmaterial-manager.js

@@ -176,9 +176,7 @@ export default class LearningMaterialManagerComponent extends Component {
     this.startDate = learningMaterial.startDate;
     this.endDate = learningMaterial.endDate;
 
-    const meshDescriptors = await learningMaterial.get('meshDescriptors');
-    this.terms = meshDescriptors.slice();
-
+    this.terms = await learningMaterial.meshDescriptors;
     this.parentMaterial = parentMaterial;
     this.type = parentMaterial.type;
     this.title = parentMaterial.title;
@@ -193,10 +191,10 @@ export default class LearningMaterialManagerComponent extends Component {
     this.filename = parentMaterial.filename;
     this.uploadDate = parentMaterial.uploadDate;
 
-    const status = await parentMaterial.get('status');
+    const status = await parentMaterial.status;
     this.statusId = status.id;
-    this.owningUser = await parentMaterial.get('owningUser');
-    const userRole = await parentMaterial.get('userRole');
+    this.owningUser = await parentMaterial.owningUser;
+    const userRole = await parentMaterial.userRole;
     this.userRoleTitle = userRole.title;
   });
 

packages/ilios-common/addon/components/learningmaterial-search.js

@@ -31,7 +31,7 @@ export default class LearningMaterialSearchComponent extends Component {
       'order_by[title]': 'ASC',
     });
 
-    const lms = results.slice();
+    const lms = results;
     this.searchReturned = true;
     this.searching = false;
     this.searchPage = 1;
@@ -59,7 +59,7 @@ export default class LearningMaterialSearchComponent extends Component {
       offset: this.searchPage * this.searchResultsPerPage,
       'order_by[title]': 'ASC',
     });
-    const lms = results.slice();
+    const lms = results;
     this.searchPage = this.searchPage + 1;
     this.hasMoreSearchResults = lms.length > this.searchResultsPerPage;
     if (this.hasMoreSearchResults) {

packages/ilios-common/addon/components/offering-calendar.js

@@ -70,7 +70,7 @@ export default class OfferingCalendar extends Component {
     } else {
       const data = await map(learnerGroups, async (learnerGroup) => {
         const offerings = await learnerGroup.offerings;
-        return await map(offerings.slice(), async (offering) => {
+        return await map(offerings, async (offering) => {
           const session = await offering.session;
           const course = await session.course;
           return {
@@ -88,7 +88,7 @@ export default class OfferingCalendar extends Component {
       });
 
       this.learnerGroupEvents = data.reduce((flattened, obj) => {
-        return [...flattened, ...obj.slice()];
+        return [...flattened, ...obj];
       }, []);
     }
 
@@ -99,7 +99,7 @@ export default class OfferingCalendar extends Component {
       const offerings = await session.offerings;
       const sessionType = await session.sessionType;
       const course = await session.course;
-      this.sessionEvents = await map(offerings.slice(), async (offering) => {
+      this.sessionEvents = await map(offerings, async (offering) => {
         return {
           startDate: DateTime.fromJSDate(offering.startDate).toISO(),
           endDate: DateTime.fromJSDate(offering.endDate).toISO(),