Skip to content

Commit

Permalink
Merge pull request #8107 from stopfstedt/the_jimi_metrics_experience
Browse files Browse the repository at this point in the history
rm obsolete ember-metrics package and the GA integration with it.
  • Loading branch information
jrjohnson authored Sep 13, 2024
2 parents 88f3b6d + 205f7b0 commit a2239b0
Show file tree
Hide file tree
Showing 8 changed files with 1 addition and 134 deletions.
11 changes: 0 additions & 11 deletions packages/frontend/app/initializers/metrics-imports.js

This file was deleted.

13 changes: 0 additions & 13 deletions packages/frontend/app/router.js
Original file line number Diff line number Diff line change
@@ -1,23 +1,10 @@
import { service } from '@ember/service';
import EmberRouter from '@embroider/router';
import config from 'frontend/config/environment';
import { courseRoutes, dashboardRoutes } from 'ilios-common/common-routes';

export default class Router extends EmberRouter {
@service iliosMetrics;
@service router;
location = config.locationType;
rootURL = config.rootURL;

constructor() {
super(...arguments);
this.on('routeDidChange', () => {
const page = this.router.currentURL;
const title = this.router.currentRouteName || 'unknown';

this.iliosMetrics.track(page, title);
});
}
}

Router.map(function () {
Expand Down
45 changes: 0 additions & 45 deletions packages/frontend/app/services/ilios-metrics.js

This file was deleted.

3 changes: 0 additions & 3 deletions packages/frontend/config/environment.js
Original file line number Diff line number Diff line change
Expand Up @@ -34,9 +34,6 @@ module.exports = function (environment) {
process.env.ILIOS_FRONTEND_ERROR_CAPTURE_ENVIRONMENT || environment,
},
},
'ember-metrics': {
includeAdapters: ['google-analytics'],
},
'ember-qunit-nice-errors': {
completeExistingMessages: true,
showFileInfo: true,
Expand Down
3 changes: 1 addition & 2 deletions packages/frontend/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -91,7 +91,6 @@
"ember-exam": "^9.0.0",
"ember-focus-trap": "^1.1.0",
"ember-load-initializers": "^2.1.2",
"ember-metrics": "1.5.2",
"ember-mirage": "^0.3.1",
"ember-modifier": "^4.1.0",
"ember-noscript": "^4.1.0",
Expand Down Expand Up @@ -158,4 +157,4 @@
"dependencies": {
"ember-auto-import": "^2.7.3"
}
}
}
33 changes: 0 additions & 33 deletions packages/frontend/tests/unit/initializers/metrics-imports-test.js

This file was deleted.

12 changes: 0 additions & 12 deletions packages/frontend/tests/unit/services/ilios-metrics-test.js

This file was deleted.

15 changes: 0 additions & 15 deletions pnpm-lock.yaml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

0 comments on commit a2239b0

Please sign in to comment.