Skip to content

Commit

Permalink
improves a11y user menu labeling.
Browse files Browse the repository at this point in the history
  • Loading branch information
stopfstedt committed Jul 14, 2023
1 parent 001a9b4 commit 353aba2
Show file tree
Hide file tree
Showing 4 changed files with 5 additions and 3 deletions.
3 changes: 1 addition & 2 deletions app/components/user-menu.hbs
Original file line number Diff line number Diff line change
@@ -1,14 +1,13 @@
<nav
class="{{if this.isOpen "is-open"}} user-menu"
aria-labelledby="user-menu-title"
aria-label={{t "general.userMenu"}}
{{did-insert (set this.element)}}
{{! template-lint-disable no-invalid-interactive }}
{{on "keyup" this.keyUp}}
data-test-user-menu
>
<button
type="button"
aria-labelledby="user-menu-title"
class="toggle"
aria-haspopup="true"
aria-expanded={{if this.isOpen "true" "false"}}
Expand Down
1 change: 1 addition & 0 deletions translations/en-us.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -441,6 +441,7 @@ general:
uploadUsers: "File with user data (csv, tsv, txt)"
userExistsInGroupHierarchy: "User already exists in top-level group {groupTitle} or one of its subgroups."
userExistsMultipleTimesInUpload: "This user already exists in the upload."
userMenu: "User menu"
username: Username
userNotAddableFromDirectory: "This user is missing required information and cannot be added"
userNotInGroupCohort: "User is not in this group's cohort: {cohortTitle}"
Expand Down
1 change: 1 addition & 0 deletions translations/es.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -441,6 +441,7 @@ general:
uploadUsers: "Archivo con datos de usuarios (csv, tsv, tx)"
userExistsInGroupHierarchy: "El usuario ya existe en el grupo de nivel superior {groupTitle} o en uno de sus subgrupos."
userExistsMultipleTimesInUpload: "Este usuario ya existe en la carga."
userMenu: "Menú del Usuario"
username: "Nombre de Usuario"
userNotAddableFromDirectory: "ste usuario está faltando información requerida y no se puede agregar"
userNotInGroupCohort: "El usuario no está en la cohorte de este grupo: {cohortTitle}"
Expand Down
3 changes: 2 additions & 1 deletion translations/fr.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -440,9 +440,10 @@ general:
uploadedGroup: "groupe a été téléversée"
uploadGroupAssignments: "téléversez travaux des groupes"
uploadUsers: "fichier de donnée utilisateurs (csv, tsv, txt)"
username: "Nom d'utilisateur"
userExistsInGroupHierarchy: "L'utilisateur existe déjà dans le groupe de niveau supérieur {groupTitle} ou dans l'un de ses sous-groupes."
userExistsMultipleTimesInUpload: "Cet utilisateur existe déjà dans le téléchargement."
userMenu: "Menu utilisateur"
username: "Nom d'utilisateur"
userNotAddableFromDirectory: "Cette utilisateur manque les informations requises, et ne peut pas être ajouté"
userNotInGroupCohort: "utilisateur introuvable dans cette groupe de cohorte: {cohortTitle}"
userRoles: "Rôles des Utilisateurs"
Expand Down

0 comments on commit 353aba2

Please sign in to comment.