Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/floating UI migartion 3083 #1

Draft
wants to merge 49 commits into
base: develop
Choose a base branch
from

Conversation

ilearnjs
Copy link
Owner

@ilearnjs ilearnjs commented Jun 7, 2023

Description

The attempt to migrate dropdown component to floating-ui

Before converting from the draft:

  • test once again
  • to check other pr's can be fixed/affected after the new implementation
  • to fix inner anchor issue (probably the old one) Need help 🆘

What is going next?

After initial code review and approve we are going to replace VaDropdown component with the current implementation.

Markup:

// Your code

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Improvement/refactoring (non-breaking change that doesn't add any feature but make things better)

gweesin and others added 30 commits April 8, 2023 21:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants