move glob exclude patterns to ignoreList #69
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
!(foo)
style clauses don't work if the codemod is extended to support incremental pod conversion. Take #61 where a--pod
flag is desired. Running--pods my-pod-a
would generate a search path like:app/my-pod-a/!(components)/**/template.hbs
but this is incorrect if you have a file structure like
since there's no folder in between
my-pod-a
and**
which matches!(components)
.The exclusion can be expressed instead with
ignoreList
so that there's no additional folders required by/!(foo)/
. This makes the codemod more extensible.I wasn't able to reproduce the issue with
--pod-path
alone like originally theorized in #61. This is because there will always be a pod-name folder to match/!(foo)/
.