Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support mypy 1.12 #882

Merged
merged 4 commits into from
Oct 15, 2024
Merged

Support mypy 1.12 #882

merged 4 commits into from
Oct 15, 2024

Conversation

glatterf42
Copy link
Member

@glatterf42 glatterf42 commented Oct 15, 2024

Our CI failed today because of the release of mypy 1.12.
This PR collects changes to adjust. It also includes a suggested change, namely to activate local_partial_type = true since this is planned to become the default with mypy 2.0. However, this setting does not seem to affect this repository too much :)

This PR is likely a prerequisite for other PRs as they won't be able to clear the code quality check before being rebased on this one.

How to review

  • Read the diff and note that the CI checks all pass.

PR checklist

  • Continuous integration checks all ✅
  • [ ] Add or expand tests; coverage checks both ✅ Just adjusting to dependency.
  • [ ] Add, expand, or update documentation. Just adjusting to dependency.
  • [ ] Update release notes. Just adjusting to dependency.

@glatterf42 glatterf42 added the enh New features & functionality label Oct 15, 2024
@glatterf42 glatterf42 self-assigned this Oct 15, 2024
Copy link

codecov bot commented Oct 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.5%. Comparing base (7700a82) to head (fd9530b).
Report is 1 commits behind head on main.

Additional details and impacted files
@@          Coverage Diff          @@
##            main    #882   +/-   ##
=====================================
  Coverage   95.5%   95.5%           
=====================================
  Files         46      46           
  Lines       4340    4340           
=====================================
  Hits        4148    4148           
  Misses       192     192           
Files with missing lines Coverage Δ
message_ix/tools/add_year/__init__.py 66.7% <ø> (ø)

- mypy v1.9.0 → v1.12.0
- ruff v0.3.4 → v0.6.9
Copy link
Member

@khaeru khaeru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added one commit so that the mypy version in .pre-commit-config.yaml is up to date with the one we use/comply with.

Beyond that, good to go.

@glatterf42 glatterf42 merged commit b5ad9d2 into main Oct 15, 2024
26 checks passed
@glatterf42 glatterf42 deleted the enh/support-mypy1.12 branch October 15, 2024 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enh New features & functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants