Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expand levelized_cost to include relation_cost #668

Draft
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

behnam-zakeri
Copy link
Contributor

This PR resolves issue #667 by adding relation_cost to the calculation of levelized_cost. It also improves the inline documentation to ensure consistency in index sets.

How to review

This is a draft at the time being. There will be tests for this when levelized_cost can be read back from GDX.

PR checklist

  • Continuous integration checks all ✅
  • Add or expand tests; coverage checks both ✅
  • Add, expand, or update documentation.
  • Update release notes.

@behnam-zakeri behnam-zakeri marked this pull request as draft November 8, 2022 10:49
@behnam-zakeri behnam-zakeri self-assigned this Nov 8, 2022
@behnam-zakeri behnam-zakeri added the enh New features & functionality label Nov 8, 2022
@behnam-zakeri
Copy link
Contributor Author

@khaeru, the lint errors here are not related to this PR (there is no change in the python code here). It seems the updated version of one or more packages creates these lint errors. Can you please check?

@khaeru
Copy link
Member

khaeru commented Nov 9, 2022

@khaeru, the lint errors here are not related to this PR (there is no change in the python code here). It seems the updated version of one or more packages creates these lint errors. Can you please check?

See iiasa/ixmp#465, from Monday.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enh New features & functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants