Add MESSAGEix-Nexus module #88
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
with message_ix_models
small fixes with updates in the source data
km3 is added for extract_freshwater_supply technology. This technology is a dummy technology and it is used for linking water commodity. At later stages, this technology will be updated. For now its better to assign Km3 as a unit.
@adrivinca for your reference. Please review the part 'Deprecated Code' in index.rst if anything needs to be changed/added. Also I added cooling.rst to. explain cooling technology implementation in detail.
moved this to message_doc and will be added as a detailed description in the documentation.
moved these to water-sectoral branch
As per MESSAGEix contributing guidelines
previously deleted accidently
The code has been edited to being able to add cooling technologies to any (pre-generated) country model generated with the 'message_single_country' approach. Minor edit in cli.py and build.py to include the country options and add attributed to the context class that are used in the data processing scripts. Fixed bug on generation of cooling shares (R script) Adapted water_for_ppl.py to allow both global and country implementation, differentiated by if conditions.
moved pre-processing scripts to data/pre-processing
Silences mypy errors.
Remove development warning in doc/water/index.rst.
|
we agree on merging it even if it reduces the coverage |
khaeru
added a commit
that referenced
this pull request
Mar 7, 2023
As noted by @glatterf42 at #88 (comment)
khaeru
added a commit
that referenced
this pull request
Apr 2, 2023
As noted by @glatterf42 at #88 (comment)
4 tasks
khaeru
added a commit
that referenced
this pull request
Aug 4, 2023
As noted by @glatterf42 at #88 (comment)
glatterf42
pushed a commit
that referenced
this pull request
Aug 7, 2023
As noted by @glatterf42 at #88 (comment)
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR migrates
.model.water(i.e. MESSAGEix-Nexus) from the (private)message_datarepo to thismessage-ix-modelspackage, following the procedure described in #89.Supersedes #86.
How to review
Note the CI checks all pass, with the exception of the coverage checks, per notes below.
PR checklist
migrate-nexus#91 into this branch.Add or expand tests; coverage checks both ✅See Add MESSAGEix-Nexus module #88 (comment); will be handled via Test and improve.model.water#93.