Skip to content

Rewrite "Final Energy|*" IAMC variables #355

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

khaeru
Copy link
Member

@khaeru khaeru commented May 22, 2025

This PR will address:

How to review

  • Read the diff.
  • Note that the CI checks all pass.
  • Check the results of using the updated code in the SSP/ScenarioMIP workflow.

PR checklist

  • Continuous integration checks all ✅
  • Add or expand tests; coverage checks both ✅
  • Add, expand, or update documentation.
  • Update doc/whatsnew.

@khaeru khaeru self-assigned this May 22, 2025
@khaeru khaeru added enh New features or functionality report genno-based reporting and post-solve processing transport MESSAGEix-Transport variant or transport in the base model p:SSP-2024 2024 SSP updates and ScenarioMIP labels May 22, 2025
Copy link

codecov bot commented May 22, 2025

Codecov Report

Attention: Patch coverage is 97.91667% with 1 line in your changes missing coverage. Please review.

Project coverage is 72.0%. Comparing base (c8ab04d) to head (e8e213c).

Files with missing lines Patch % Lines
message_ix_models/project/ssp/transport.py 97.0% 1 Missing ⚠️
Additional details and impacted files
@@          Coverage Diff          @@
##            main    #355   +/-   ##
=====================================
  Coverage   72.0%   72.0%           
=====================================
  Files        243     243           
  Lines      19451   19474   +23     
=====================================
+ Hits       14011   14035   +24     
+ Misses      5440    5439    -1     
Files with missing lines Coverage Δ
...sage_ix_models/tests/project/ssp/test_transport.py 100.0% <100.0%> (+2.0%) ⬆️
message_ix_models/project/ssp/transport.py 96.2% <97.0%> (+0.3%) ⬆️

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@khaeru khaeru force-pushed the project/ssp/transport/fe branch from c6c3b65 to 1316502 Compare May 23, 2025 07:03
khaeru added 2 commits May 23, 2025 09:21
- New function broadcast_t_fe().
- Update test expectations.
@khaeru khaeru force-pushed the project/ssp/transport/fe branch from 1316502 to c1b6918 Compare May 23, 2025 07:23
@khaeru khaeru added this to the 2025-07 milestone May 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enh New features or functionality p:SSP-2024 2024 SSP updates and ScenarioMIP report genno-based reporting and post-solve processing transport MESSAGEix-Transport variant or transport in the base model
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant