Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Data prep / analysis / viz of Climate data #47

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

jkikstra
Copy link

There are two options for this:
(a) as is: use pre-prepped temperature data for the figures;
(b) include all original temperature data.

For (a), there are of course multiple options, depending on how much climate data we want to pre-process and commit here. For now, I have gone with:

  • minimal data
  • maximal meta

For (b), if this is desired, I'd need to do an extra commit, which will have a data upload of up to ~11GB.

Additional question: are there no license issues here?

@jkikstra
Copy link
Author

jkikstra commented May 30, 2023

Two parts for the reviewer:

Does the code work
To check: pull the PR, click on the .RProj, and try to run. Check if there's no errors (minimum), and if the figures and table numbers are the same (desirable criterion), and whether the code is understandable and makes sense (desirable criterion).

Does the placement make sense
It probably is up to Daniel&Ed (or whomever is in charge of the data publication part) to decide whether the structure makes sense.

@jkikstra jkikstra marked this pull request as ready for review June 2, 2023 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant