fix error in gi & hsr: always return success 200

ihsangan · Oct 29, 2024 · 3404322 · 3404322
1 parent 6fd11f0
commit 3404322
Show file tree

Hide file tree

Showing 2 changed files with 32 additions and 16 deletions.
diff --git a/src/router/gi.ts b/src/router/gi.ts
@@ -24,7 +24,7 @@ export default async function gi(id: number): Promise<Result> {
     default:
       return {
         success: false,
-        message: 'Bad request'
+        message: 'Not found'
       };
   }
   const body = `voucherPricePoint.id=116054&voucherPricePoint.price=16500&voucherPricePoint.variablePrice=0&user.userId=${id}&user.zoneId=${sv}&voucherTypeName=GENSHIN_IMPACT&shopLang=id_ID`;
@@ -34,11 +34,19 @@ export default async function gi(id: number): Promise<Result> {
     body
   });
   const data = await response.json();
-  return {
-    success: true,
-    game: 'Genshin Impact',
-    id,
-    server: sn,
-    name: data.confirmationFields.username
-  };
+  if (data.confirmationFields.username) {
+    return {
+      success: true,
+      game: 'Genshin Impact',
+      id,
+      server: sn,
+      name: data.confirmationFields.username
+    };
+  }
+  else {
+    return {
+      success: false,
+      message: 'Not found'
+    }
+  }
 }
diff --git a/src/router/hsr.ts b/src/router/hsr.ts
@@ -24,7 +24,7 @@ export default async function hsr(id: number): Promise<Result> {
     default:
       return {
         success: false,
-        message: 'Bad request',
+        message: 'Not found',
       };
   }
   const body = `voucherPricePoint.id=855316&voucherPricePoint.price=16000&voucherPricePoint.variablePrice=0&user.userId=${id}&user.zoneId=${sv}&voucherTypeName=HONKAI_STAR_RAIL&shopLang=id_ID`;
@@ -34,11 +34,19 @@ export default async function hsr(id: number): Promise<Result> {
     body
   });
   const data = await response.json();
-  return {
-    success: true,
-    game: 'Honkai: Star Rail',
-    id,
-    server: sn,
-    name: data.confirmationFields.username
-  };
+  if (data.confirmationFields.username) {
+    return {
+      success: true,
+      game: 'Honkai: Star Rail',
+      id,
+      server: sn,
+      name: data.confirmationFields.username
+    }
+  }
+  else {
+    return {
+      success: false,
+      message: 'Not found'
+    }
+  }
 }