WIP: closing in on full model #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aflaxman
requested review from
albrja,
hussain-jafari,
patricktnast,
rmudambi and
stevebachmeier
as code owners
albrja
reviewed
Aug 27, 2024
| @@ -188,12 +188,10 @@ def sodium_effect_on_sbp(self, index, sbp_drop_value): | |||
| sodium_exposure = self.sodium_exposure(index) | |||
| sodium_exposure_raw = self.sodium_exposure_raw(index) | |||
|
|
|||
| sodium_threshold = 2.0 # g/day | |||
| mmHg_per_g_sodium = 10 # mmHg increase per 1g sodium above threshold | |||
| mmHg_per_g_sodium = 5.8/6.0 # 5.8 (2.5, 9.2) mmHg decrease per 6g/day sodium decrease | |||
|
|
|||
There was a problem hiding this comment.
Consider putting this in a constants file
albrja
approved these changes
Aug 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Title: Model extensions to go from minimal model to "full" model
From minimal model to fullDescription
Changes and notes
add more causes, risk effects, scenarios, and refine model parametersVerification and Testing
runs successfully.