add blurbs about NonLogLinearRiskEffect #477
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stevebachmeier
requested review from
albrja,
collijk,
hussain-jafari,
patricktnast and
rmudambi
as code owners
| @@ -324,8 +319,10 @@ def _get_risk_exposure_class(self, builder: Builder) -> Risk: | |||
|
|
|||
|
|
|||
| class NonLogLinearRiskEffect(RiskEffect): | |||
| """A component to model the impact of an exposure-parametrized risk factor on | |||
| the target rate of some affected entity. | |||
| """A component to model the effect of an exposure-parametrized risk factor. | |||
There was a problem hiding this comment.
"the exposure-parametrized effect of a risk factor" is more accurate.
hussain-jafari
approved these changes
Aug 28, 2024
rmudambi
approved these changes
Aug 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Minor cleanup to risk exposure tutorial
Description
Changes and notes
The tutorials are pretty light as is and thankfully don't refer to codeblocks line-by-line like in vivarium. All I've done here is add to it saying
that there is now a NonLogLinearRiskEffect and then a corresponding
todo.
There is nothing about observers so this task is otherwise a won't do.
Testing