Albrja/mic 5383/psimulate clock configuration #236
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
albrja
requested review from
collijk,
hussain-jafari,
patricktnast,
rmudambi and
stevebachmeier
as code owners
rmudambi
requested changes
Oct 4, 2024
| end_time = pd.Timestamp(**sim.configuration.time.end.to_dict()) | ||
| step_size = pd.Timedelta(days=sim.configuration.time.step_size) | ||
| num_steps = int(math.ceil((end_time - start_time) / step_size)) | ||
| num_steps = sim.get_number_of_steps(start_time) |
There was a problem hiding this comment.
We shouldn't be providing start time to this method.
There was a problem hiding this comment.
But we have to get it from the Parallel sim context or the backups
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Albrja/mic 5383/psimulate clock configuration
Updates how vivarium work horse gets number of simulation steps
Changes and notes
-Updates vivarium work horse method to get number of steps from InteractiveContext method
Testing
Successfully ran parallel simulation with custom clock