mypy fixes tests/framework/components/test_manager.py #586
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stevebachmeier
requested review from
albrja,
collijk,
hussain-jafari,
patricktnast and
rmudambi
as code owners
albrja
approved these changes
Feb 12, 2025
stevebachmeier
commented
Feb 12, 2025
| @@ -295,9 +295,12 @@ def _get_file(component: Component | Manager) -> str: | |||
| return inspect.getfile(component.__class__) | |||
|
|
|||
| @staticmethod | |||
| def _flatten(components: list[Component | Manager]) -> list[Component | Manager]: | |||
| def _flatten( | |||
| components: Sequence[Component | Manager | Sequence[Any]], | |||
There was a problem hiding this comment.
Where are we on type-hinting nested things? This method flattens a list of lists of arbitrary depth, so I just went w/ Any
There was a problem hiding this comment.
I recall this is similar to the grief we had in LCT, but fwiw supposedly you can do recursive type aliases
https://stackoverflow.com/questions/53638973/recursive-type-annotations?rq=4
stevebachmeier
commented
Feb 12, 2025
| with pytest.raises(ComponentConfigError, match="no name"): | ||
| _ = 10 in component_list | ||
| _ = 10 in component_list # type: ignore[operator] |
There was a problem hiding this comment.
ignoring b/c it's precisely what we're ensuring raises
patricktnast
approved these changes
Feb 13, 2025
stevebachmeier
force-pushed
the
sbachmei/mic-5712/mypy-test-manager
branch
from
e1d176d to
5dd8723
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
mypy fix tests/framework/components/test_manager.py
Description
Changes and notes
Testing