Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Settings + signal model for categorical pipeline #15

Merged
merged 6 commits into from
Sep 4, 2024

Conversation

n-gilbertson
Copy link
Contributor

@n-gilbertson n-gilbertson commented Aug 30, 2024

  • Created default settings for the categorical pipeline
  • Fit and plot signal model – coefficients, data, outliers.
  •  (Is there a better way to get the betas, thinking particularly about the addition of covariates later on and extracting the intercept betas appropriately – using get_beta_info function from utils maybe?)
    
  • Add entry point for categorical pipeline
  • Set things up to ignore .DS_Store files (maybe – if implemented correctly)

@n-gilbertson n-gilbertson requested a review from zhengp0 August 30, 2024 17:52

# get bias covariates that need to be removed
all_covs = [col for col in df.columns if col.startswith("cov_")]
covs_to_remove = [col for col in all_covs if len(df[col].unique()) == 1]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

here we probably can use

df[col].unique() == 1

But we can make this chance along with removing columns with only several 1s or 0s. And also in other types of pipelines

Copy link
Member

@zhengp0 zhengp0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Nora!! Everything looks good to me and we can merge this PR :)

@n-gilbertson n-gilbertson merged commit d0df991 into cat_dev Sep 4, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants