Skip to content

Commit

Permalink
set use_re=f in signal_model, adjust ROS calc to use maxBPRF
Browse files Browse the repository at this point in the history
  • Loading branch information
n-gilbertson committed Nov 8, 2024
1 parent 473e998 commit 44a1288
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions src/bopforge/categorical_pipeline/functions.py
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ def get_signal_model(settings: dict, df: DataFrame) -> MRBRT:
ref_cov="ref_risk_cat",
ref_cat=settings["cat_cov_model"]["ref_cat"],
prior_order=settings["cat_cov_model"]["prior_order"],
use_re=True,
use_re=False,
)
]

Expand Down Expand Up @@ -481,7 +481,7 @@ def get_linear_model_summary(
# Number of alternative categories
n = pred.size - 1
# Index with largest signed coefficient
max_idx = np.argmax(sign * pred)
max_idx = np.argmax(signed_bprf)
if np.any(np.prod(inner_ui[:,], axis=0) < 0):
summary["score"] = float("nan")
summary["star_rating"] = 0
Expand Down

0 comments on commit 44a1288

Please sign in to comment.