Rename Pipeline.data to Pipeline.grouby_data #123
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e docstring; replace instances of Pipeline.data including in refs to json config keys; tests passing
kels271828
approved these changes
Dec 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Addressing MSCA-361. Mini-PR to rename
Pipeline.datatoPipeline.groupby_dataas discussed, in order to make the role of the attribute more clear.Changes made
Pipeline.datatoPipeline.groupby_datagroupbyandgroupby_dataReviewer instructions
Especially review the new docstring description and feel free to directly propose additions or changes to wording! I personally don't mind longer and more detailed docstrings as appropriate.
Additional notes
groupbywith examples in documentation will be key to making the usage clear.