feature/jobmon_resources #118
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhengp0
approved these changes
Dec 11, 2024
zhengp0
reviewed
Dec 12, 2024
| @@ -34,7 +34,6 @@ | |||
| from pathlib import Path | |||
| from typing import Literal | |||
|
|
|||
| import yaml | |||
There was a problem hiding this comment.
Highly recommend ruff pre-commit
https://github.com/astral-sh/ruff-pre-commit
it will automatically detect the unused import and fix it :)
There was a problem hiding this comment.
I had formatting on save but it wasn't working today for some reason. I had to update a vscode extension and now it is working again :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow user to pass a dictionary of compute resources or a path to a resources file (any format that can be loaded by
ConfigLoader) toevaluate_with_jobmonand pipeline/stageevaluatemethods. Previously only paths to yaml files were valid.