-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bugfix/minor_updates #115
Merged
Merged
bugfix/minor_updates #115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…be defined by class
…e customized model higher priority compare to buildin stage
Some of these changes might need to be revisited in separate PRs. Will create tickets in JIRA. |
zhengp0
approved these changes
Dec 6, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes look good to me! Thanks @kels271828! Indeed we need to fix the tests soon.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DESCRIPTION
Updates to get codem pipeline running.
FIXED
DataInterface
classDataInterface
classmkdir
statement toDataIO.dump()
main.load_stage()
when custom stage has same name as built-in stagesubsets.create_subsets()
back to pandas and added sorting for consistent subset_id assignmentADDED
dataif
syntax in stage/base.pyModelStage.get_stage_subset()
to make it more generalizable__repr__
functionsREMOVED
PreprocessingStage
andPreprocessingConfig
(various files)CHANGED
stages
arg inevaluate_jobmon()
andevaluate_local()
from list to set for consistency; addedstages
arg toPipeline.get_execution_order()
and moved where function gets called fromPipeline.evaluate()
toevaluate_jobmon()
andevaluate_local()
stage_name
arg tostages
in main.pycollect
method on a pipeline from main.py to pipeline.py, added error check for callingcollect
method on aStage
instance (as opposed toModelStage
) or with Jobmon backend to stage/base.pyPipeline.check_upstream_output_exists()
toInput.check_missing()
, added calls toInput.check_missing()
inPipeline.evaluate()
andStage.evaluate()
Stage.input
andStage.output
items inStage.set_dataif
TODO