-
Notifications
You must be signed in to change notification settings - Fork 387
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to use Java 17 #1315
Update to use Java 17 #1315
Conversation
[group: 'com.sparkjava', name: 'spark-core', version: '2.2'], | ||
[group: 'org.glassfish.jersey.core', name: 'jersey-common', version: '2.22.4'] | ||
) | ||
testRuntimeOnly( | ||
[group: 'org.junit.vintage', name:'junit-vintage-engine', version:'5.8.2'] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This test runtime dependency is the engine that runs junit4 tests since gradle seems to assume you're using 5 now.
@@ -243,32 +224,32 @@ tasks.distTar.enabled = false | |||
tasks.startScripts.enabled = false | |||
|
|||
task createDistZip(type: Zip, dependsOn: createDist) { | |||
archiveName = "IGV_${version}.zip" | |||
archiveFileName = "IGV_${archiveVersion}.zip" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The name changes are all to satisfy gradle deprecation complaints.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, looks good
Looks good to me. Glad to see those hacks in I'll note there a warning / non-fatal error when building on my Linux laptop:
I have no idea if Mac or Windows builds report the same. This seems to be a Gradle bug that they claim is Closed. My take is that this doesn't affect anything and can be ignored at least for now, but you might want to keep an eye on it. |
Great job! But I got this error when I run
|
* change to gradle 8.0.2 * minor changes to support java 17 * remove test module configuration and use gradle test platform instead
b3b9b74
to
fcf2300
Compare
…change some 11's to 17s
@hubutui the "createDist" problem is fixed. |
This updates to use / require java 17.
I first tried to update the test module settings and ran into trouble. It seems like removing all of the test module settings completely works though. I set it to use the gradle junit platform settings which may be doing that in the background now.
Tests seem to run locally and on github without problems so I think it seems to be working.
I also update the versions of the github actions since they were using deprecated versions.