-
Notifications
You must be signed in to change notification settings - Fork 387
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Fixing a rounding error in calculateZoom. Instead of rounding to the closest integer zoom level I believe we should be rounding up to the nearest zoom level which can contain the given window. This fixes a display issue with the ZoomSliderPanel. I'm not 100% sure I understand the potential consequences of changing thhis for other code that relies on it, so it would be good to have a second pair of eyes on it. It seems intuitively to be correct now but it's possible the use case of "zoom level which is closest to the width of the given window" was really what was wanted. I haven't found any obvious issues with some manual testing of this change.
- Loading branch information
1 parent
2d82d8e
commit 0138f1a
Showing
2 changed files
with
10 additions
and
4 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters