Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: improve test-dot.product.game #1705

Merged
merged 3 commits into from
Feb 20, 2025
Merged

test: improve test-dot.product.game #1705

merged 3 commits into from
Feb 20, 2025

Conversation

maelle
Copy link
Contributor

@maelle maelle commented Feb 20, 2025

Fix #1396

  • Is this correct?
  • What should the title be?
  • Afterwards I'll merge into the correct test file.

@maelle maelle requested a review from schochastics February 20, 2025 09:26
@aviator-app Aviator app
Copy link
Contributor

aviator-app bot commented Feb 20, 2025 •
edited
Loading

Current Aviator status

Aviator will automatically update this comment as the status of the PR changes.
Comment /aviator refresh to force Aviator to re-examine your PR (or learn about other /aviator commands).

This PR was merged manually (without Aviator). Merging manually can negatively impact the performance of the queue. Consider using Aviator next time.

See the real-time status of this PR on the Aviator webapp.
Use the Aviator Chrome Extension to see the status of your PR within GitHub.

schochastics
schochastics reviewed Feb 20, 2025
View reviewed changes
Copy link
Contributor

@schochastics schochastics left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, just update the title :)

@maelle maelle enabled auto-merge (squash) February 20, 2025 12:09
@maelle maelle merged commit 71bb392 into main Feb 20, 2025
11 checks passed
@maelle maelle deleted the dot.product.game branch February 20, 2025 12:33
schochastics added a commit to schochastics/rigraph that referenced this pull request Feb 21, 2025
@maelle @schochastics
test: improve test-dot.product.game, fold into test-games (igraph#1705)
af75817 
Co-authored-by: David Schoch <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@schochastics schochastics schochastics left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

fix test-dot.product.game
2 participants
@maelle @schochastics