Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: hrg functions check their argument #1699

Merged
merged 2 commits into from
Feb 20, 2025
Merged

feat: hrg functions check their argument #1699

merged 2 commits into from
Feb 20, 2025

Conversation

maelle
Copy link
Contributor

@maelle maelle commented Feb 19, 2025

Fix #1074

@szhorvat for info I could only find two functions with HRG as input (well there are methods but methods don't need to check the class if I follow correctly)

@maelle maelle requested a review from schochastics February 19, 2025 16:43
Copy link
Contributor

aviator-app bot commented Feb 19, 2025

Current Aviator status

Aviator will automatically update this comment as the status of the PR changes.
Comment /aviator refresh to force Aviator to re-examine your PR (or learn about other /aviator commands).

This PR was merged manually (without Aviator). Merging manually can negatively impact the performance of the queue. Consider using Aviator next time.


See the real-time status of this PR on the Aviator webapp.
Use the Aviator Chrome Extension to see the status of your PR within GitHub.

Copy link
Contributor

@schochastics schochastics left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@maelle maelle merged commit e0879d9 into main Feb 20, 2025
12 checks passed
@maelle maelle deleted the HRG branch February 20, 2025 10:46
schochastics pushed a commit to schochastics/rigraph that referenced this pull request Feb 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

HRG functions do not check arguments
2 participants