feat: Split sample_bipartite() into two functions for the G(n, m) a…
#1692
Conversation
Current Aviator status
This pull request is currently open (not queued). How to mergeTo merge this PR, comment
See the real-time status of this PR on the
Aviator webapp.
Use the Aviator Chrome Extension
to see the status of your PR within GitHub.
|
| on.exit( .Call(R_igraph_finalizer) ) | ||
| # Function call | ||
| res <- .Call(R_igraph_bipartite_game_gnp, n1, n2, p, directed, mode) | ||
| res <- set_vertex_attr(res$graph, "type", value = res$types) |
There was a problem hiding this comment.
@Antonov548 I mean this line in this and the other function. Furthermore there should be NO
if (igraph_opt("add.vertex.names") && is_named(graph)) {
names(res) <- vertex_attr(graph, "name")
}
Thanks!
There was a problem hiding this comment.
Hello @maelle
I just took a look how to update generation to match with existing code. It is just first time we setting vertex attribute in generated interface.
I think I understand why names(res$types) <- vertex_attr(graph, "name", V(graph)) is not needed, but do we really need to set_vertex_attr()? I just trying to understand it in order to decide how to update stimulus part.
There was a problem hiding this comment.
Hi @Antonov548 maybe we could add set_vertex_attr() in the not automatic code. Let me discuss this with @krlmlr and @schochastics and then I'll update this thread (within the next few weeks). Thank you.
There was a problem hiding this comment.
maybe we could add
set_vertex_attr()in the not automatic code.
Good. To be honest I think not automatic code maybe it better place for setting up the attributes. I will wait for the decision.
There was a problem hiding this comment.
If we change in the template, how many functions will be affected?
@Antonov548: Can you please adapt the template and run the generation? We can revert later if needed.
| on.exit( .Call(R_igraph_finalizer) ) | ||
| # Function call | ||
| res <- .Call(R_igraph_bipartite_game_gnp, n1, n2, p, directed, mode) | ||
| res <- set_vertex_attr(res$graph, "type", value = res$types) |
There was a problem hiding this comment.
If we change in the template, how many functions will be affected?
@Antonov548: Can you please adapt the template and run the generation? We can revert later if needed.
R/games.R
Outdated
| } | ||
|
|
||
| utils::globalVariables("type") |
Co-authored-by: Kirill Müller <[email protected]>
| ) | ||
| bipartite_gnm(...) | ||
| } else { | ||
| cli::cli_abort( |
There was a problem hiding this comment.
this would be the case where the user passes sthg else than NULL, "gnp" or gnm"."
|
A few comments here need addressing. |
…nd G(n, p) case
Fix #630
@Antonov548 could you please help me update Stimulus to get the functions as they are now in aaa-auto.R?