Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: prevent decompose() test from being reported as skipped #1128

Merged
merged 1 commit into from
Jan 21, 2024

Conversation

szhorvat
Copy link
Member

I guess this test didn't need any explicit check, but without one it will be reported as skipped.

@szhorvat szhorvat requested a review from krlmlr January 21, 2024 20:03
Copy link
Contributor

aviator-app bot commented Jan 21, 2024

Current Aviator status

Aviator will automatically update this comment as the status of the PR changes.
Comment /aviator refresh to force Aviator to re-examine your PR (or learn about other /aviator commands).

This PR was merged using Aviator.


See the real-time status of this PR on the Aviator webapp.

Use the Aviator Chrome Extension to see the status of your PR within GitHub.

@krlmlr krlmlr changed the title tests: prevent decompose() test from being reported as skipped tests: prevent decompose() test from being reported as skipped Jan 21, 2024
@krlmlr krlmlr changed the title tests: prevent decompose() test from being reported as skipped test: prevent decompose() test from being reported as skipped Jan 21, 2024
Copy link
Contributor

@krlmlr krlmlr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. It's better to have an expectation in each test, to avoid the noise.

@aviator-app aviator-app bot merged commit a61a593 into main Jan 21, 2024
14 checks passed
@aviator-app aviator-app bot deleted the tests/decompose branch January 21, 2024 21:37
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 21, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants