Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: advance lifecycle deprecation from soft to warn #1120

Closed
wants to merge 3 commits into from

Conversation

maelle
Copy link
Contributor

@maelle maelle commented Jan 16, 2024

No description provided.

@maelle maelle requested a review from krlmlr January 16, 2024 09:12
Copy link
Contributor

aviator-app bot commented Jan 16, 2024

Current Aviator status

Aviator will automatically update this comment as the status of the PR changes.
Comment /aviator refresh to force Aviator to re-examine your PR (or learn about other /aviator commands).

This PR was closed without merging. If you still want to merge this PR, re-open it.


See the real-time status of this PR on the Aviator webapp.
Use the Aviator Chrome Extension to see the status of your PR within GitHub.

@krlmlr
Copy link
Contributor

krlmlr commented Jan 16, 2024

Happy to run revdepchecks once the build is green.

@krlmlr krlmlr marked this pull request as draft January 16, 2024 09:57
@aviator-app aviator-app bot removed the mergequeue label Jan 16, 2024
Copy link
Contributor

aviator-app bot commented Jan 16, 2024

This pull request can't be queued because it's currently a draft.

@maelle
Copy link
Contributor Author

maelle commented Jan 16, 2024

@krlmlr the build is green now 😇 could you please run revdeps checks? 🙏 thank you!

@krlmlr
Copy link
Contributor

krlmlr commented Jan 20, 2024

Nice! I'd like to tackle this after the 2.0.0 release. The goal of that release is to use the new C core.

@krlmlr krlmlr modified the milestones: upgrade-2, upkeep Jan 20, 2024
@maelle maelle modified the milestones: upkeep, upgrade-2 Jan 29, 2024
@maelle
Copy link
Contributor Author

maelle commented Jan 29, 2024

What's the next version number? Could you please run revdeps checks for this branch?

@krlmlr
Copy link
Contributor

krlmlr commented Feb 1, 2024

For the change from soft to warn, do we really advance the version number?

I feel it's a little too early for that. Should we first move everything to {lifecycle} and give downstream some time to adapt? I suspect most users aren't even aware of the API change.

@maelle
Copy link
Contributor Author

maelle commented Feb 5, 2024

For the change from soft to warn, do we really advance the version number?

Oh right, no.

I feel it's a little too early for that. Should we first move everything to {lifecycle} and give downstream some time to adapt? I suspect most users aren't even aware of the API change.

Ok.

@maelle maelle closed this Feb 5, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 5, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants