Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: get.edge.ids(multi = TRUE) is no longer supported #1101

Merged
merged 4 commits into from
Jan 20, 2024

Conversation

krlmlr
Copy link
Contributor

@krlmlr krlmlr commented Jan 11, 2024

Closes #1097.

Copy link
Contributor

aviator-app bot commented Jan 11, 2024

Current Aviator status

Aviator will automatically update this comment as the status of the PR changes.
Comment /aviator refresh to force Aviator to re-examine your PR (or learn about other /aviator commands).

This PR was merged using Aviator.


See the real-time status of this PR on the Aviator webapp.

Use the Aviator Chrome Extension to see the status of your PR within GitHub.

@krlmlr krlmlr marked this pull request as draft January 11, 2024 23:57
@aviator-app aviator-app bot added the blocked label Jan 11, 2024
Copy link
Contributor

aviator-app bot commented Jan 11, 2024

This pull request failed to merge: this PR is in draft state. Remove the blocked label to re-queue.

Additional debug info: PR was marked as draft after queueing

@krlmlr krlmlr force-pushed the f-1097-edge-ids-multi branch from 3b4918a to 439b154 Compare January 11, 2024 23:59
@aviator-app aviator-app bot removed the mergequeue label Jan 11, 2024
Copy link
Contributor

aviator-app bot commented Jan 11, 2024

This pull request can't be queued because it's currently a draft.

@krlmlr krlmlr force-pushed the f-1097-edge-ids-multi branch from 439b154 to 5af6314 Compare January 12, 2024 05:46
@krlmlr krlmlr removed the blocked label Jan 12, 2024
@krlmlr krlmlr marked this pull request as ready for review January 12, 2024 05:47
@aviator-app aviator-app bot force-pushed the f-1097-edge-ids-multi branch from 5af6314 to f4af68b Compare January 12, 2024 05:47
@aviator-app aviator-app bot added the blocked label Jan 12, 2024
Copy link
Contributor

aviator-app bot commented Jan 12, 2024

This pull request failed to merge: some CI status(es) failed. Remove the blocked label to re-queue.

Failed CI(s): Coverage

@krlmlr krlmlr force-pushed the f-1097-edge-ids-multi branch from f4af68b to 91e567b Compare January 13, 2024 15:39
@krlmlr krlmlr removed the blocked label Jan 13, 2024
@aviator-app aviator-app bot added the blocked label Jan 13, 2024
Copy link
Contributor

aviator-app bot commented Jan 13, 2024

This pull request failed to merge: some CI status(es) failed. Remove the blocked label to re-queue.

Failed CI(s): Sanitizer

@krlmlr
Copy link
Contributor Author

krlmlr commented Jan 13, 2024

The SAN failures are a consequence of a mismatch between Docker image and version of the Matrix package. We might see failures in the mainline too. I tried to fix the root cause, let's see if the fix was successful.

@krlmlr krlmlr removed the blocked label Jan 14, 2024
@aviator-app aviator-app bot added the blocked label Jan 14, 2024
Copy link
Contributor

aviator-app bot commented Jan 14, 2024

This pull request failed to merge: some CI status(es) failed. Remove the blocked label to re-queue.

Failed CI(s): Sanitizer

@krlmlr krlmlr removed the blocked label Jan 16, 2024
@aviator-app aviator-app bot force-pushed the f-1097-edge-ids-multi branch from 7b4ee0b to 42082d7 Compare January 16, 2024 10:27
@aviator-app aviator-app bot added the blocked label Jan 16, 2024
Copy link
Contributor

aviator-app bot commented Jan 16, 2024

This pull request failed to merge: some CI status(es) failed. Remove the blocked label to re-queue.

Failed CI(s): Check ubuntu-20.04 (oldrel-2), Check ubuntu-20.04 (oldrel-4)

@krlmlr krlmlr removed the blocked label Jan 20, 2024
@aviator-app aviator-app bot force-pushed the f-1097-edge-ids-multi branch from 289921a to d131a7c Compare January 20, 2024 16:02
@krlmlr krlmlr added this to the upgrade milestone Jan 20, 2024
@aviator-app aviator-app bot merged commit f425694 into main Jan 20, 2024
14 checks passed
@aviator-app aviator-app bot deleted the f-1097-edge-ids-multi branch January 20, 2024 16:32
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 20, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

get.edge.ids() broken in 2.0
2 participants