ci: Add required rgl version

igraph · Nov 18, 2024 · a55b0ad · a55b0ad
1 parent 7590e28
commit a55b0ad
Show file tree

Hide file tree

Showing 3 changed files with 2 additions and 4 deletions.
diff --git a/.github/workflows/build-and-check.yml b/.github/workflows/build-and-check.yml
@@ -253,8 +253,6 @@ jobs:
           run: |
             set -e
             printenv
-            # Memory leaks with rgl 1.3.12, https://github.com/dmurdoch/rgl/issues/439
-            RDcsan -e 'pak::pak("dmurdoch/rgl")'
             cd rigraph
             RDcsan CMD INSTALL . --no-byte-compile
             TESTTHAT_PARALLEL=false CI=true RDcsan -q -e 'testthat::test_local(reporter = c("location", "summary"), load_package = "installed")'
diff --git a/DESCRIPTION b/DESCRIPTION
@@ -49,7 +49,7 @@ Suggests:
     digest,
     igraphdata,
     knitr,
-    rgl,
+    rgl (>= 1.3.14),
     rmarkdown,
     scales,
     stats4,

diff --git a/tests/testthat/test-plot.R b/tests/testthat/test-plot.R
@@ -73,7 +73,7 @@ test_that("basic plot test, spheres", {
 })
 
 test_that("rglplot() works", {
-  skip_if_not_installed("rgl")
+  skip_if_not_installed("rgl", "1.3.14")
 
   # https://stackoverflow.com/a/46320771/5489251
   withr::local_envvar(RGL_USE_NULL = TRUE)
-Original file line number
+Diff line change
@@ Expand Up / @@ -49,7 +49,7 @@ Suggests: @@
         digest,
         igraphdata,
         knitr,
-        rgl,
+        rgl (>= 1.3.14),
         rmarkdown,
         scales,
         stats4,
@@ Expand Down @@