Skip to content

Commit

Permalink
chore: formally deprecate similarity.<something>() functions (#1515)
Browse files Browse the repository at this point in the history
  • Loading branch information
aviator-app[bot] authored Sep 19, 2024
2 parents 8c7d368 + 98083ca commit 7e2c5fe
Show file tree
Hide file tree
Showing 5 changed files with 177 additions and 12 deletions.
96 changes: 86 additions & 10 deletions R/similarity.R
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@
#' Eytan Adar: Friends and neighbors on the Web. Social Networks,
#' 25(3):211-230, 2003.
#'
#' @aliases similarity.jaccard similarity.dice similarity.invlogweighted
#' @aliases similarity.invlogweighted
#' @param graph The input graph.
#' @param vids The vertex ids for which the similarity is calculated.
#' @param mode The type of neighboring vertices to use for the calculation,
Expand All @@ -44,6 +44,7 @@
#' @keywords graphs
#' @family similarity
#' @family cocitation
#' @cdocs igraph_similarity_jaccard igraph_similarity_dice igraph_similarity_inverse_log_weighted
#' @export
#' @examples
#'
Expand All @@ -62,20 +63,95 @@ similarity <- function(graph, vids = V(graph),
)) {
method <- igraph.match.arg(method)
if (method == "jaccard") {
similarity.jaccard(graph, vids, mode, loops)
similarity_jaccard_impl(graph, vids, mode, loops)
} else if (method == "dice") {
similarity.dice(graph, vids, mode, loops)
similarity_dice_impl(graph, vids, mode, loops)
} else if (method == "invlogweighted") {
similarity.invlogweighted(graph, vids, mode)
similarity_inverse_log_weighted_impl(graph, vids, mode)
}
}

#' Similarity measures of two vertices (Jaccard)
#'
#' @description
#' `r lifecycle::badge("deprecated")`
#'
#' Please use [`similarity()`] with `method = "jaccard"` instead.
#' @inheritParams similarity
#' @keywords internal
#' @export
#' @cdocs igraph_similarity_jaccard
similarity.jaccard <- similarity_jaccard_impl
similarity.jaccard <- function(graph,
vids = V(graph),
mode = c("all", "out", "in", "total"),
loops = FALSE) {
similarity(
graph = graph,
vids = vids,
mode = mode,
loops = loops,
method = "jaccard"
)

lifecycle::deprecate_soft(
"2.0.4",
"similarity.jaccard()",
'similarity(method)',
details = 'similarity(method = "jaccard")'
)
}

#' Similarity measures of two vertices (Dice)
#'
#' @description
#' `r lifecycle::badge("deprecated")`
#'
#' Please use [`similarity()`] with `method = "dice"` instead.
#' @inheritParams similarity
#' @keywords internal
#' @export
#' @cdocs igraph_similarity_dice
similarity.dice <- similarity_dice_impl
similarity.dice <- function(graph,
vids = V(graph),
mode = c("all", "out", "in", "total"),
loops = FALSE) {
similarity(
graph = graph,
vids = vids,
mode = mode,
loops = loops,
method = "dice"
)

lifecycle::deprecate_soft(
"2.0.4",
"similarity.dice()",
'similarity(method)',
details = 'similarity(method = "dice")'
)
}

#' Similarity measures of two vertices (inverse log-weighted)
#'
#' @description
#' `r lifecycle::badge("deprecated")`
#'
#' Please use [`similarity()`] with `method = "invlogweighted"` instead.
#' @inheritParams similarity
#' @keywords internal
#' @export
#' @cdocs igraph_similarity_inverse_log_weighted
similarity.invlogweighted <- similarity_inverse_log_weighted_impl
similarity.invlogweighted <- function(graph,
vids = V(graph),
mode = c("all", "out", "in", "total")) {
similarity(
graph = graph,
vids = vids,
mode = mode,
method = "invlogweighted"
)

lifecycle::deprecate_soft(
"2.0.4",
"similarity.invlogweighted()",
'similarity(method)',
details = 'similarity(method = "invlogweighted")'
)
}
4 changes: 2 additions & 2 deletions man/similarity.Rd

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

31 changes: 31 additions & 0 deletions man/similarity.dice.Rd

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

27 changes: 27 additions & 0 deletions man/similarity.invlogweighted.Rd

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

31 changes: 31 additions & 0 deletions man/similarity.jaccard.Rd

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

0 comments on commit 7e2c5fe

Please sign in to comment.