test: merged and refactored topology.R tests (#1720)

igraph · Feb 27, 2025 · 39fb16d · 39fb16d
1 parent d61a908
commit 39fb16d
Show file tree

Hide file tree

Showing 13 changed files with 317 additions and 319 deletions.
diff --git a/R/topology.R b/R/topology.R
@@ -239,10 +239,10 @@ graph.subisomorphic.lad <- function(pattern, target, domains = NULL,
   all.maps <- as.logical(all.maps)
   if (!is.null(domains)) {
     if (!is.list(domains)) {
-      stop("`domains' must be a list of vertex vectors from `target'")
+      cli::cli_abort("{.arg domains} must be a list of vertex vectors from {.arg target}.")
     }
     if (length(domains) != vcount(pattern)) {
-      stop("`domains' length and `pattern' number of vertices must match")
+      cli::cli_abort("{.arg domains} length and {.arg pattern} number of vertices must match.")
     }
     domains <- lapply(domains, function(x) as_igraph_vs(target, x) - 1)
   }

diff --git a/...ps/bug-501-rectangles/rectangle-edges.svg → .../testthat/_snaps/plot/rectangle-edges.svg b/...ps/bug-501-rectangles/rectangle-edges.svg → .../testthat/_snaps/plot/rectangle-edges.svg
diff --git a/tests/testthat/test-bug-1032819.R b/tests/testthat/test-bug-1032819.R
diff --git a/tests/testthat/test-bug-154.R b/tests/testthat/test-bug-154.R
diff --git a/tests/testthat/test-bug-501-rectangles.R b/tests/testthat/test-bug-501-rectangles.R
diff --git a/tests/testthat/test-canonical.permutation.R b/tests/testthat/test-canonical.permutation.R
diff --git a/tests/testthat/test-graph.isoclass.R b/tests/testthat/test-graph.isoclass.R
diff --git a/tests/testthat/test-graph.subisomorphic.lad.R b/tests/testthat/test-graph.subisomorphic.lad.R
diff --git a/tests/testthat/test-graph.subisomorphic.vf2.R b/tests/testthat/test-graph.subisomorphic.vf2.R
diff --git a/tests/testthat/test-isomorphism.R b/tests/testthat/test-isomorphism.R
diff --git a/tests/testthat/test-notable.R b/tests/testthat/test-notable.R
diff --git a/tests/testthat/test-plot.R b/tests/testthat/test-plot.R
@@ -109,3 +109,23 @@ test_that("label colors are correct when loops are present", {
     }
   )
 })
+
+test_that("Edges stop at outside of rectangle node", {
+  skip_if_not_installed("vdiffr")
+
+  rectangle_edges <- function() {
+    g <- make_graph(c(1, 2, 1, 4, 2, 1, 2, 5, 2, 3, 4, 1, 5, 2, 3, 2))
+    layout <- cbind(
+      c(-2.01, -1.16, -1.24, -2.74, -0.13),
+      c(1.27, 2.1, 3.14, 0.56, 2.01)
+    )
+    plot(g,
+      vertex.size = 30,
+      vertex.color = rgb(0.1, 0.7, 0.8, 0.1),
+      vertex.shape = "rectangle",
+      layout = layout
+    )
+  }
+
+  vdiffr::expect_doppelganger("rectangle-edges", rectangle_edges)
+})