Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Geolocation API #84

Merged
merged 37 commits into from
Aug 1, 2024
Merged

Geolocation API #84

merged 37 commits into from
Aug 1, 2024

Conversation

igorkamyshev
Copy link
Owner

@igorkamyshev igorkamyshev commented Apr 17, 2024 •
edited
Loading

fixes #12

  • tests for reporting and failures
  • tests for default geolocation in non-browser environment
  • create custom providers once, stop recreating them on every call
  • live demo in docs

@cloudflare-workers-and-pages Cloudflare Workers and Pages
Copy link

cloudflare-workers-and-pages bot commented Apr 17, 2024 •
edited
Loading

Deploying withease with  Cloudflare Pages  Cloudflare Pages

Latest commit: bca44eb
Status: ✅  Deploy successful!
Preview URL: https://1eb872b7.withease.pages.dev
Branch Preview URL: https://geolocation.withease.pages.dev

View logs

@igorkamyshev igorkamyshev marked this pull request as ready for review April 29, 2024 05:32
AlexandrHoroshih
AlexandrHoroshih approved these changes Apr 29, 2024
View reviewed changes
Copy link
Collaborator

@AlexandrHoroshih AlexandrHoroshih left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall: awesome! 👍

apps/website/docs/web-api/geolocation.md Show resolved Hide resolved
packages/web-api/src/geolocation.ts Outdated Show resolved Hide resolved
@igorkamyshev igorkamyshev merged commit 55266ec into master Aug 1, 2024
12 checks passed
@igorkamyshev igorkamyshev deleted the geolocation branch August 1, 2024 11:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlexandrHoroshih AlexandrHoroshih AlexandrHoroshih approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support Geolocation API in @withease/web-api
2 participants
@igorkamyshev @AlexandrHoroshih