-
Notifications
You must be signed in to change notification settings - Fork 130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
π€οΈ Migrate to the Compose Multiplatform Navigation #779
Open
igorescodro
wants to merge
11
commits into
main
Choose a base branch
from
update/navigation
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A new Compose Navigation dependency was added once Voyager doesn't seem to be maintained anymore.
New destinations and events were created to represent all the app's screens and how to interact between them.
Initial structure connecting the AndroidX Navigation with our custom implementation created.
All the existing destinations were migrated from Voyager to the new navigation system. Future commits will handle the deep links and port more destinations (such as confirmation dialogs) to this system.
Bye, bye, my friend!
Name updated
New mandatory tag added after updating Compose
Since Compose Multiplatform does not fully support deep links, the initial implementation was created, and it will be updated when the support is ready. For now, every deep link will simply open Alkaa's main screen.
A new module and a Wrapper to provide the `PermissionsController` instance. This class holds a single instance of `PermissionsController` since Moko does not allow `BindEffect` to be called outside an Activity context (Alkaa uses in a `dialog` destination).
The behavior for keep the tab state after rotating the screen was re-introduced. Small changes were needed to ensure the data can be properly stored in the `Bundle`.
After the recent updates, the `rememberSaveable` for the `LocalDateTime` was not working properly. For now, the value will be stored as a `Long` and converted to DateTime as needed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migrating to the new Compose Multiplatform Navigation library and implementing a new navigation system based on events.