Speed up download statistics #274
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hardcodes the download statistics for all projects prior to 2024-09-18 00:00:00. The database query will now only count all downloads since that timestamp. This saves ~30 seconds on some page loads, as we're asking the database to count 32 million records less.
akrherz
reviewed
Sep 19, 2024
| @@ -40,7 +40,7 @@ public class DownloadStats extends HttpServlet { | |||
| private static final String ADD_UPDATE_INFO = "insert into checkUpdateInfo (ipAddress, os, type, time, country, region, city, currentVersion, latestVersion) values (INET_ATON(?),?,?,NOW(),?,?,?,?,?)"; | |||
|
|
|||
| // SQL for counting the total number of downloads by type. | |||
| private static String COUNT_TOTAL_DOWNLOADS_BY_TYPE = "SELECT type, count(type) FROM downloadInfo GROUP BY type"; | |||
| private static String COUNT_TOTAL_DOWNLOADS_BY_TYPE_SINCE = "SELECT type, count(type) FROM downloadInfo WHERE time > '2024-09-18 00:00:00' GROUP BY type;"; | |||
There was a problem hiding this comment.
It's ignored by the driver, but I'll remove it :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hardcodes the download statistics for all projects prior to 2024-09-18 00:00:00. The database query will now only count all downloads since that timestamp.
This saves ~30 seconds on some page loads, as we're asking the database to count 32 million records less.