Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: default flag parser for apps (backport #4483) #4488

Open
wants to merge 1 commit into
base: release/v28.x.y
Choose a base branch
from

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Feb 1, 2025

Fix default values for app flags, it always gets zero if the value is not set


This is an automatic backport of pull request #4483 done by Mergify.

* fix default flag parse for apps

* remove bug condition

* fix. unit tests

* add changelog

---------

Co-authored-by: Julien Robert <[email protected]>
(cherry picked from commit 7f91423)

# Conflicts:
#	ignite/services/plugin/flag_test.go
#	ignite/services/plugin/grpc/v1/interface_flag.go
Copy link
Contributor Author

mergify bot commented Feb 1, 2025

Cherry-pick of 7f91423 has failed:

On branch mergify/bp/release/v28.x.y/pr-4483
Your branch is up to date with 'origin/release/v28.x.y'.

You are currently cherry-picking commit 7f914230.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   changelog.md
	modified:   ignite/services/plugin/flag.go

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   ignite/services/plugin/flag_test.go
	both modified:   ignite/services/plugin/grpc/v1/interface_flag.go

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

@github-actions github-actions bot added component:ci CI/CD workflow and automated jobs. component:configs type:services Service-related issues. labels Feb 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:ci CI/CD workflow and automated jobs. component:configs conflicts type:services Service-related issues.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant