Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: bump cometbft to 0.38.15 #4471

Merged
merged 5 commits into from
Jan 15, 2025
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions .github/workflows/gen-docs-cli.yml
Original file line number Diff line number Diff line change
@@ -13,7 +13,7 @@ jobs:

- uses: actions/setup-go@v4
with:
go-version: '1.21'
go-version: 'stable'

- name: Generate CLI Docs
run: ./scripts/gen-cli-docs
@@ -31,4 +31,3 @@ jobs:
run: |
echo "Pull Request Number - ${{ steps.cpr.outputs.pull-request-number }}"
echo "Pull Request URL - ${{ steps.cpr.outputs.pull-request-url }}"
4 changes: 2 additions & 2 deletions .github/workflows/go-formatting.yml
Original file line number Diff line number Diff line change
@@ -3,7 +3,7 @@ on:
push:
branches: [main]
paths:
- '**.go'
- "**.go"

jobs:
go-formatting:
@@ -15,7 +15,7 @@ jobs:
- name: Install Go
uses: actions/setup-go@v4
with:
go-version: '1.21'
go-version: 'stable'

- name: Run make format
run: make format
2 changes: 1 addition & 1 deletion .github/workflows/release-binary.yml
Original file line number Diff line number Diff line change
@@ -18,7 +18,7 @@ jobs:
- name: Set up Go
uses: actions/setup-go@v4
with:
go-version: "1.21"
go-version: 'stable'

- name: Checkout
uses: actions/checkout@v3
2 changes: 1 addition & 1 deletion .github/workflows/release-snapcraft.yml
Original file line number Diff line number Diff line change
@@ -16,7 +16,7 @@ jobs:
- name: Set up Go
uses: actions/setup-go@v4
with:
go-version: "1.21"
go-version: 'stable'

- name: Checkout
uses: actions/checkout@v4
2 changes: 1 addition & 1 deletion .gitpod.Dockerfile
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
FROM gitpod/workspace-full

# Go
ENV GO_VERSION=1.21.5
ENV GO_VERSION=1.23.4
ENV GOPATH=$HOME/go-packages
ENV GOROOT=$HOME/go
ENV PATH=$GOROOT/bin:$GOPATH/bin:$PATH
8 changes: 4 additions & 4 deletions Dockerfile
Original file line number Diff line number Diff line change
@@ -3,13 +3,13 @@

## prep the base image.
#
FROM golang:1.21.5 as base
FROM golang:latest as base

RUN apt update && \
apt-get install -y \
build-essential \
ca-certificates \
curl
build-essential \
ca-certificates \
curl

# enable faster module downloading.
ENV GOPROXY https://proxy.golang.org
5 changes: 5 additions & 0 deletions changelog.md
Original file line number Diff line number Diff line change
@@ -2,6 +2,11 @@

## Unreleased

### Changes

- [#4471](https://github.com/ignite/cli/pull/4471) Bump CometBFT to v0.38.15.
- [#4471](https://github.com/ignite/cli/pull/4471) Bump Ignite & chain minimum Go version to 1.23.

## [`v28.7.0`](https://github.com/ignite/cli/releases/tag/v28.7.0)

### Features
2 changes: 1 addition & 1 deletion docs/docs/01-welcome/02-install.md
Original file line number Diff line number Diff line change
@@ -24,7 +24,7 @@ Ignite CLI is supported for the following operating systems:

Ignite CLI is written in the Go programming language. To use Ignite CLI on a local system:

- Install [Go](https://golang.org/doc/install) (**version 1.21.1** or higher)
- Install [Go](https://golang.org/doc/install) (**version 1.23** or higher)
- Ensure the Go environment variables are [set properly](https://golang.org/doc/gopath_code#GOPATH) on your system

## Verify your Ignite CLI version
142 changes: 70 additions & 72 deletions go.mod

Large diffs are not rendered by default.

469 changes: 156 additions & 313 deletions go.sum

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion ignite/pkg/xast/xast.go
Original file line number Diff line number Diff line change
@@ -32,7 +32,7 @@ func Inspect(n ast.Node, f func(n ast.Node) error) (err error) {

// ParseDir invokes ast.ParseDir and returns the first package found that is
// doesn't has the "_test" suffix.
func ParseDir(dir string) (*ast.Package, *token.FileSet, error) {
func ParseDir(dir string) (*ast.Package, *token.FileSet, error) { //nolint:staticcheck,nolintlint
fileSet := token.NewFileSet()
pkgs, err := parser.ParseDir(fileSet, dir, nil, 0)
if err != nil {
2 changes: 1 addition & 1 deletion ignite/pkg/xstrings/xstrings.go
Original file line number Diff line number Diff line change
@@ -1,10 +1,10 @@
package xstrings

import (
"slices"
"strings"
"unicode"

"golang.org/x/exp/slices" // TODO: replace with slices.Contains when it will be available in stdlib (1.21)
"golang.org/x/text/cases"
"golang.org/x/text/language"
)
2 changes: 1 addition & 1 deletion ignite/services/plugin/template/go.mod.plush
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
module <%= AppName %>

go 1.21
go 1.23

require (
github.com/hashicorp/go-plugin v1.6.0
8 changes: 4 additions & 4 deletions ignite/templates/app/files/go.mod.plush
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
module <%= ModulePath %>

go 1.21
go 1.23

replace (
// fix upstream GHSA-h395-qcrw-5vmq vulnerability.
@@ -16,7 +16,7 @@ require (
cosmossdk.io/depinject v1.1.0
cosmossdk.io/errors v1.0.1
cosmossdk.io/log v1.4.1
cosmossdk.io/math v1.4.0
cosmossdk.io/math v1.5.0
cosmossdk.io/store v1.1.1
cosmossdk.io/tools/confix v0.1.2
cosmossdk.io/x/circuit v0.1.1
@@ -28,7 +28,7 @@ require (
github.com/cosmos/interchain-security/v5 v5.2.0
<% } %>
github.com/bufbuild/buf v1.34.0
github.com/cometbft/cometbft v0.38.12
github.com/cometbft/cometbft v0.38.15
github.com/cosmos/cosmos-db v1.1.0
github.com/cosmos/cosmos-proto v1.0.0-beta.5
github.com/cosmos/cosmos-sdk v0.50.11
@@ -48,5 +48,5 @@ require (
google.golang.org/genproto/googleapis/api v0.0.0-20241118233622-e639e219e697
google.golang.org/grpc v1.68.0
google.golang.org/grpc/cmd/protoc-gen-go-grpc v1.3.0
google.golang.org/protobuf v1.35.2
google.golang.org/protobuf v1.36.1
)
2 changes: 1 addition & 1 deletion scripts/indocker
Original file line number Diff line number Diff line change
@@ -3,7 +3,7 @@
function build {
echo "building container..."
docker build -t ignite-cli -f - > /dev/null . << EOF
FROM golang:1.21.5
FROM golang:latest
WORKDIR /apps