refactor(services): add suggestions for logging on serve failure (backport #3943)
#3946
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![mergify[bot]](https://avatars.githubusercontent.com/in/10562?s=60&v=4){kind=small}
…3943) Currently when `serve` fails, it shows ``` Blockchain failed to start. If the new code is no longer compatible with the saved state, you can reset the database by launching: ignite chain serve --reset-once ``` Considering this will the entry point for many folks new to Ignite, probably adding a suggestion for verbose logging is a trivial, but helpful addition. Cheers. (cherry picked from commit 86df442)
mergify
bot
requested review from
ilgooz,
jeronimoalbi,
Pantani,
julienrbrt and
Ehsan-saradar
as code owners
github-actions
bot
added
component:ci
julienrbrt
approved these changes
Feb 5, 2024
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## release/v28.x.y #3946 +/- ##
================================================
Coverage 24.78% 24.78%
================================================
Files 296 296
Lines 24901 24901
================================================
Hits 6171 6171
Misses 18164 18164
Partials 566 566
|
jeronimoalbi
approved these changes
Feb 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automatic backport of pull request #3943 done by Mergify.
Mergify commands and options
More conditions and actions can be found in the documentation.
You can also trigger Mergify actions by commenting on this pull request:
@Mergifyio refreshwill re-evaluate the rules@Mergifyio rebasewill rebase this PR on its base branch@Mergifyio updatewill merge the base branch into this PR@Mergifyio backport <destination>will backport this PR on<destination>branchAdditionally, on Mergify dashboard you can:
Finally, you can contact us on https://mergify.com