Skip to content

Commit

Permalink
fix: Apps Stdout is redirected to Stderr (#3953)
Browse files Browse the repository at this point in the history
* Fix stdout redirecting to stderr

* Fix unit test

* Update changelog

(cherry picked from commit ca4445e)
  • Loading branch information
Ehsan-saradar authored and mergify[bot] committed Feb 6, 2024
1 parent af25183 commit 0fae165
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 3 deletions.
2 changes: 2 additions & 0 deletions changelog.md
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,8 @@

- [#3905](https://github.com/ignite/cli/pull/3905) Fix `ignite completion`
- [#3931](https://github.com/ignite/cli/pull/3931) Fix `app update` command and duplicated apps
- [#3931](https://github.com/ignite/cli/pull/3931) Fix `app update` command and duplicated apps
- [#3953](https://github.com/ignite/cli/pull/3953) Fix apps `Stdout` is redirected to `Stderr`

## [`v28.1.1`](https://github.com/ignite/cli/releases/tag/v28.1.1)

Expand Down
5 changes: 2 additions & 3 deletions ignite/services/plugin/plugin.go
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,6 @@ func CollectEvents(ev events.Bus) Option {
func RedirectStdout(w io.Writer) Option {
return func(p *Plugin) {
p.stdout = w
p.stderr = w
}
}

Expand Down Expand Up @@ -272,8 +271,8 @@ func (p *Plugin) load(ctx context.Context) {
HandshakeConfig: HandshakeConfig(),
Plugins: pluginMap,
Logger: logger,
SyncStderr: p.stdout,
SyncStdout: p.stderr,
SyncStdout: p.stdout,
SyncStderr: p.stderr,
AllowedProtocols: []hplugin.Protocol{hplugin.ProtocolGRPC},
}

Expand Down

0 comments on commit 0fae165

Please sign in to comment.