Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show Inbox number on mobile #1220

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Show Inbox number on mobile #1220

wants to merge 1 commit into from

Conversation

dfabulich
Copy link
Collaborator

@dfabulich dfabulich commented Dec 16, 2024

Menu closed

image

Menu open

Note: We're showing the number twice. Is that bad? I guess I prefer it…?

image

Dark mode

image

@dfabulich
Copy link
Collaborator Author

@alice-blue

@alice-blue
Copy link
Contributor

alice-blue commented Dec 16, 2024

Having the number next to "inbox" in the drop-down menu makes sense. I'm not sure how understandable it will be to also have it show up next to "menu." (There are 17 menu items? 17 new menu items?) But I guess people will figure it out if they click menu, and then see the matching number next to inbox. Another option might be to just have a colored circle/dot next to "Menu" (maybe smaller) without a number inside, just to indicate something new, but I don't know how to make that screen-reader friendly.

@dfabulich
Copy link
Collaborator Author

dfabulich commented Dec 16, 2024

Another idea I toyed with was to hide the number in the "Menu" button when you expand the menu, but that made the Menu either scoot around in a way that didn't feel good, or have weird blank space where the hidden number occupies space.

This was the best option I could come up with, but I still don't feel totally satisfied with it.

@alice-blue
Copy link
Contributor

alice-blue commented Dec 16, 2024

I don't think it's a big deal to have the number shown twice. I'd be a little more concerned about confusion than redundance. (And it's the fact that the number is next to the word "menu" that makes it potentially confusing.) The only other thing I can think of is to put some kind of icon there next to "Menu" instead of a circle (maybe an envelope icon? A red one, even?) and have alt text for it. You wouldn't necessarily need a number there. But this also seems like the kind of thing we can improve later if we think of a better idea.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants