Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove extra • separator before empty game metadata fields #420

Merged
merged 1 commit into from
Sep 2, 2024

Conversation

Keltena
Copy link
Contributor

@Keltena Keltena commented Sep 2, 2024

Entry listings on /ballot and /comp include a bullet after each metadata field. This works as long as the last field (platform) isn't blank:

Horror • Half an hour • Web-based

However, the platform field is left blank if set to "Other", which results in dangling separators:

Fantasy • Two hours •

This pull request tweaks the template to print separators only between two non-empty fields.

(A simpler fix would be to just print "Other", but I'm assuming that decision was made for a reason.)

@coveralls
Copy link

Coverage Status

coverage: 63.298%. remained the same
when pulling a9f70e0 on Keltena:entry-metadata-display
into de7eb0e on iftechfoundation:main.

@mjmusante mjmusante merged commit c7f4e69 into iftechfoundation:main Sep 2, 2024
2 checks passed
@Keltena Keltena deleted the entry-metadata-display branch September 4, 2024 01:19
@Keltena Keltena mentioned this pull request Sep 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants