Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add remaining dark mode colors (fixes #394, #395) #405

Merged
merged 7 commits into from
Aug 4, 2024

Conversation

Keltena
Copy link
Contributor

@Keltena Keltena commented Aug 4, 2024

This pull request:

  • Adds a dark mode palette for the .alert-danger and .alert-success infobox classes (based on existing dark mode colors for alert-info), and the .btn-danger and .btn-success button classes (based on existing dark mode colors for .btn-primary)
  • Changes the dark-red warning label on form fields with errors to light red in dark mode
  • Fixes a few borders I missed last time, as well as a place where buttons were falling back to light-mode colors

This fixes #395, and should fully fix #394 if I haven't missed anything.

@coveralls
Copy link

Coverage Status

coverage: 65.299%. remained the same
when pulling 588419f on Keltena:css-fixes
into b60f63b on iftechfoundation:main.

@mjmusante mjmusante merged commit bcf237d into iftechfoundation:main Aug 4, 2024
2 checks passed
@Keltena Keltena deleted the css-fixes branch August 5, 2024 00:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dark mode background color sometimes overrides button color Certain elements lack dark mode colors
3 participants