Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make app dockerfile work on Windows #391

Merged
merged 1 commit into from
Jul 11, 2024
Merged

Make app dockerfile work on Windows #391

merged 1 commit into from
Jul 11, 2024

Conversation

Keltena
Copy link
Contributor

@Keltena Keltena commented Jul 11, 2024

Docker can't directly run docker_start.sh from a mounted Windows directory because Windows lacks executable file permissions. This fixes that issue, which caused the app to crash on startup.

@Keltena
Fix issue where docker_start.sh fails to run from a mounted Windows d…
41a1c65 
…irectory due to lack of executable permissions.

(for details, see:
docker/compose#2301 (comment)
)
@coveralls
Copy link

Coverage Status

coverage: 65.299%. remained the same
when pulling 41a1c65 on Keltena:win-compatibility-fixes
into 8681489 on iftechfoundation:main.

@mjmusante mjmusante merged commit 296ce38 into iftechfoundation:main Jul 11, 2024
2 checks passed
@Keltena Keltena deleted the win-compatibility-fixes branch August 4, 2024 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Keltena @coveralls @mjmusante