Toggle resource recommendations #1738
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…TeamBits-2020/ifme into toggle_resource_recommendations
…rrect props for resource recommendations toggle
S-Warmenhoven
requested review from
julianguyen,
nshki,
bmwachajr,
hmasila and
asquare14
julianguyen
previously approved these changes
May 8, 2020
app/views/moments/show.html.erb
Outdated
| </ul> | ||
| </div> | ||
| <% if @moment.resource_recommendations? %> | ||
| <% if @resources.any? %> |
There was a problem hiding this comment.
We should combine these conditions with &&.
There was a problem hiding this comment.
Thank you for the speedy feedback, @julianguyen! I'll fix that right away.
julianguyen
previously approved these changes
May 8, 2020
There was a problem hiding this comment.
LGTM, solid work! I think we should hold back on merging since we're doing a feature freeze today.
cc: @bmwachajr
|
Looks like this is ready to merge! Let's just resolve the merge conflicts :) |
julianguyen
approved these changes
May 11, 2020
bmwachajr
pushed a commit
that referenced
this pull request
May 20, 2020
* [#1737] Display new toggle button on Moment edit page * Add resource_recommendation column on moments table * [#1737] Toggle works for moment new and edit * [#1737] Refactored and rubocop * [#1737] Translation for Hindi * [#1737] Translate Norwegian * [#1737] Translate Dutch * [#1737] Translate Swedish * [#1737] Translate Vietnamese * [#1737] Add resource_recommendation column on moments table * [#1737] Toggle works for moment new and edit * [#1737] Refactored and rubocop * [#1737] Transalte resource_recommendations into Brazilian Portuguese * [#1737] Transalte resource_recommendations into Spanish * [#1737] Translate German * [#1737] Transalte resource_recommendations into French * [#1737] Transalte resource_recommendations into Italian * [#1737] Transalte resource_recommendations into Chinese * [#1737] Fix French translation * [#1737] Test if MomentsFormHelper #edit and #create returns correct props for resource recommendations toggle * [#1737] Test if toggle updates moment.resource_recommendations in db * [#1737] Test if correct links are displayed on moment show * [#1737] Test if resource links are not displayed when user chooses so * [#1737] Updated schema and seed file * [#1737] Refactored code to be dry Co-authored-by: Aline Ribeiro <[email protected]>
bianca93
pushed a commit
to bianca93/ifme
that referenced
this pull request
Jun 24, 2020
* [ifmeorg#1737] Display new toggle button on Moment edit page * Add resource_recommendation column on moments table * [ifmeorg#1737] Toggle works for moment new and edit * [ifmeorg#1737] Refactored and rubocop * [ifmeorg#1737] Translation for Hindi * [ifmeorg#1737] Translate Norwegian * [ifmeorg#1737] Translate Dutch * [ifmeorg#1737] Translate Swedish * [ifmeorg#1737] Translate Vietnamese * [ifmeorg#1737] Add resource_recommendation column on moments table * [ifmeorg#1737] Toggle works for moment new and edit * [ifmeorg#1737] Refactored and rubocop * [ifmeorg#1737] Transalte resource_recommendations into Brazilian Portuguese * [ifmeorg#1737] Transalte resource_recommendations into Spanish * [ifmeorg#1737] Translate German * [ifmeorg#1737] Transalte resource_recommendations into French * [ifmeorg#1737] Transalte resource_recommendations into Italian * [ifmeorg#1737] Transalte resource_recommendations into Chinese * [ifmeorg#1737] Fix French translation * [ifmeorg#1737] Test if MomentsFormHelper #edit and #create returns correct props for resource recommendations toggle * [ifmeorg#1737] Test if toggle updates moment.resource_recommendations in db * [ifmeorg#1737] Test if correct links are displayed on moment show * [ifmeorg#1737] Test if resource links are not displayed when user chooses so * [ifmeorg#1737] Updated schema and seed file * [ifmeorg#1737] Refactored code to be dry Co-authored-by: Aline Ribeiro <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Created a toggle for a user to choose to display/not display Resource Recommendations on their Moment Post show page.
More Details
Important! A resource_recommendations boolean column has been added to the Moments table. The necessary steps as per Schema Documentation Best Practices have been taken. Additionally, the seeds.rb file has been updated for the user moments.
Corresponding Issue
Issue #1737
Reviewing this pull request? Check out our Code Review Practices guide if you haven't already!