Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update text in test file to be consistent with naming #1216

Merged
merged 1 commit into from
Oct 28, 2018
Merged

Update text in test file to be consistent with naming #1216

merged 1 commit into from
Oct 28, 2018

Conversation

toryalsip
Copy link
Contributor

Description

While I was doing some initial work on #1215 I noticed there is some text descriptions that didn't align with the tests. It appears to be a copy-paste error where the name is prefixed devise_invitable_ when I think it should be kaminari_. I would like to fix these up before I go much farther with the translation work I'm on right now.

Test Coverage

@toryalsip toryalsip self-assigned this Oct 28, 2018
@toryalsip toryalsip requested a review from julianguyen October 28, 2018 00:29
@welcome
Copy link

welcome bot commented Oct 28, 2018

Thank you for opening this pull request with us! Be sure to follow our Pull Request Practices. Let us know if you have any questions on Slack.

Copy link
Member

@julianguyen julianguyen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@julianguyen julianguyen merged commit 92eb9f7 into ifmeorg:master Oct 28, 2018
@welcome
Copy link

welcome bot commented Oct 28, 2018

Thank you for merging this pull request with us! If you haven't already, in another pull request, please add yourself to our Contribute page.

@toryalsip toryalsip deleted the fix-locale-test-text branch October 29, 2018 23:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants