Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pull] master from nccgroup:master #14

Open
wants to merge 1,248 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1248 commits
Select commit Hold shift + click to select a range
d757816
Add services
x4v13r64 May 13, 2022
8714bf4
Add services
x4v13r64 May 13, 2022
9414c24
Add services
x4v13r64 May 13, 2022
41e5e05
Basic Functions support
x4v13r64 May 13, 2022
b82a450
Implement basic BigQuery support
x4v13r64 May 13, 2022
e8703ca
Improve service enabled check
x4v13r64 May 13, 2022
ef7875f
Update SQS encryption finding to for managed SSE
charlietran May 14, 2022
66e830e
better implementation
x4v13r64 May 17, 2022
65f7941
Improve implementation
x4v13r64 May 17, 2022
660cff6
Improve implementation
x4v13r64 May 17, 2022
337b383
Add IAM informatino
x4v13r64 May 17, 2022
db36914
Format service names
x4v13r64 May 17, 2022
c89f521
Working parsing and rendering
x4v13r64 May 17, 2022
f52eb00
Add resources
x4v13r64 May 17, 2022
5cd31d5
Get non provider IDs
x4v13r64 May 17, 2022
02f7b6e
Reformat
x4v13r64 May 17, 2022
cdeb557
Add base partials
x4v13r64 May 17, 2022
c8a6132
Better parsing and rendering
x4v13r64 May 17, 2022
c1193e1
Better parsing and rendering
x4v13r64 May 17, 2022
55ee5ea
Add finding
x4v13r64 May 18, 2022
f921014
Add finding
x4v13r64 May 18, 2022
f4f42a7
Add finding
x4v13r64 May 18, 2022
b8600c0
Show potential secrets
x4v13r64 May 18, 2022
35a63a2
Check for secrets
x4v13r64 May 18, 2022
7fd0af7
Add rules
x4v13r64 May 18, 2022
e2c2e17
Complete secrets identification implementation
x4v13r64 May 18, 2022
76a1958
Add rule
x4v13r64 May 18, 2022
c090068
Add rule
x4v13r64 May 18, 2022
05efd63
Update prose
x4v13r64 May 18, 2022
40997ea
Fix class element
x4v13r64 May 18, 2022
b014ce4
Add rule
x4v13r64 May 18, 2022
af5feb8
Add rule
x4v13r64 May 18, 2022
4f1c41a
Add field
x4v13r64 May 18, 2022
515d049
Add prose
x4v13r64 May 18, 2022
9f51fb9
Better presentation
x4v13r64 May 18, 2022
bf172f6
Merge pull request #1365 from nccgroup/fix/1356
x4v13r64 May 18, 2022
8018698
Sorted rulesets
x4v13r64 May 18, 2022
c33696a
Merge branch 'enhancement/new-gcp-services' into develop-latacora
x4v13r64 May 18, 2022
6d1dd81
Sorted rulesets
x4v13r64 May 18, 2022
dab56bc
Merge https://github.com/nccgroup/ScoutSuite/pull/1420
x4v13r64 May 18, 2022
21500d3
Merge branch 'rbailey-godaddy-bugfix/userdata-secrets-regexs' into de…
x4v13r64 May 18, 2022
6cd534d
Merge branch 'Yashvendra-bugfix/cloudwatch-iam-policy-changes' into d…
x4v13r64 May 18, 2022
ed9b74c
Add latest policies
x4v13r64 May 20, 2022
c523720
Merge branch 'enhancement/elb-update-policies' into develop-latacora
x4v13r64 May 20, 2022
8a23084
Add unit tests for regex fix
rscottbailey May 26, 2022
2f16303
Disable and annotate new unit test
rscottbailey May 26, 2022
58aa638
Merge pull request #1425 from nccgroup/develop-latacora
michyweb Jun 3, 2022
95297c6
add DeviceCodeCredential authentication
fernando-gallego Jun 3, 2022
3fe5cde
Disable throttling check
fernando-gallego Jun 3, 2022
5a591de
Handle Graph API 404 responses
fernando-gallego Jun 3, 2022
28d5bb2
Handle VMs without diagnostics profile
fernando-gallego Jun 3, 2022
dd405f6
Disable KeyVault diagnostic settings checks
fernando-gallego Jun 3, 2022
4eaaae1
Disable KeyVault logging and diagnostic settings rules
fernando-gallego Jun 3, 2022
0bddd9b
Disable KeyVault logging and diagnostic settings rules
fernando-gallego Jun 3, 2022
230bd2a
Workaround for MissingApiVersionParameter error
fernando-gallego Jun 3, 2022
0706135
Better parsing
x4v13r64 Jun 3, 2022
877ed8b
Address https://github.com/nccgroup/ScoutSuite/issues/1415
x4v13r64 Jun 9, 2022
8adc2db
Updated dotnet current versions from 4.0 to 6.0
Jun 17, 2022
bb8d13e
Remove duplicate link
tkmru Jun 27, 2022
430025d
Fix docker-compose build error
Anthirian Jul 7, 2022
c6eca9d
Version update
Jul 15, 2022
3ea07c9
Merge pull request #1430 from kronicd/develop
michyweb Aug 26, 2022
aed8f74
The phone in azure means a phone number
tkmru Aug 28, 2022
4509aee
Merge pull request #1448 from tkmru/fix/azure-phone
fernando-gallego Aug 31, 2022
233ab7c
Merge pull request #1438 from Anthirian/master
fernando-gallego Aug 31, 2022
c70528b
Merge pull request #1431 from tkmru/fix-duplicate-link
fernando-gallego Aug 31, 2022
03bc585
Merge pull request #1426 from nccgroup/bugfix/issues/1415
fernando-gallego Aug 31, 2022
66a6de7
Merge pull request #1418 from rbailey-godaddy/bugfix/userdata-secrets…
fernando-gallego Aug 31, 2022
59b0315
Update __init__.py
fernando-gallego Sep 1, 2022
4dfd04c
Update AWS IPs
fernando-gallego Sep 1, 2022
3faf763
Add flag to authenticate against an AWS China region
Sep 1, 2022
5de8a96
Merge branch 'develop' of github.com:nccgroup/ScoutSuite into develop
Sep 1, 2022
ee4fd9a
removed unnecessary print
Sep 1, 2022
4dd7eb4
removed unnecessary argument, minor refactor of the latest feature
Sep 1, 2022
56de0be
Fix AWS when building for arm64
FlorinAsavoaie Sep 2, 2022
01428f5
Revert "removed unnecessary argument, minor refactor of the latest fe…
fernando-gallego Sep 2, 2022
8e37d90
Revert "removed unnecessary print"
fernando-gallego Sep 2, 2022
d064666
Revert "Add flag to authenticate against an AWS China region"
fernando-gallego Sep 2, 2022
6b8debb
Merge pull request #1453 from nccgroup/develop
fernando-gallego Sep 5, 2022
732bd73
fixing typo
yaleman Sep 9, 2022
41e360e
Handle empty function 'maxInstances'
fernando-gallego Sep 15, 2022
4799df8
docs.microsoft.com->learn.microsoft.com
tkmru Sep 19, 2022
b9c47f2
Merge pull request #1459 from tkmru/fix/docs-to-learn
michyweb Sep 21, 2022
dff1a4b
Merge pull request #1456 from yaleman/typo
michyweb Sep 21, 2022
888916f
Merge pull request #1452 from FlorinAsavoaie/fix/aws-arm64
michyweb Sep 21, 2022
5507cc6
Kubescout Alpha
liyun-li Sep 22, 2022
cf44beb
Merge pull request #1460 from liyun-li/develop
michyweb Sep 22, 2022
5e1fdf8
restructured the way docker is handled
rossja Sep 24, 2022
44c9e2c
rm compose to eliminate confusion
rossja Sep 24, 2022
8887ad2
azure/rules/findings/rbac-administering-resource-locks-assigned.json:…
elimisteve Sep 29, 2022
b324389
Exclude SMTP port 25 from rule
rbailey-godaddy Oct 5, 2022
981670f
Bug fix
liyun-li Oct 5, 2022
3d5a1aa
Secret redaction logic improvement
liyun-li Oct 6, 2022
d6e0e28
Add checks on lists because why not
liyun-li Oct 6, 2022
3e3fd65
remove unnecessary typing
liyun-li Oct 10, 2022
6563ac8
Merge pull request #1468 from liyun-li/develop
michyweb Oct 11, 2022
d3002c2
Format findings
x4v13r64 Oct 20, 2022
d56bf14
Format findings
x4v13r64 Oct 20, 2022
79667f1
Format findings
x4v13r64 Oct 20, 2022
7403e8b
Support LBs
x4v13r64 Oct 20, 2022
860cdb2
Support additional parameters
x4v13r64 Oct 20, 2022
9315ae0
Add default values
x4v13r64 Oct 21, 2022
a32df60
Add findings
x4v13r64 Oct 21, 2022
1b6aa70
Format
x4v13r64 Oct 21, 2022
75c8b68
Format
x4v13r64 Oct 21, 2022
9e8bbc8
Catch task exceptions
x4v13r64 Oct 21, 2022
ba8e184
Catch ranges from 1-65535
x4v13r64 Oct 27, 2022
a748c41
Better logic
x4v13r64 Oct 27, 2022
5c29988
Improve rule
x4v13r64 Oct 27, 2022
ec8fa81
Add missing rule to ruleset
x4v13r64 Oct 27, 2022
65a8bf5
Evaluate public access prevention
x4v13r64 Oct 27, 2022
884d41f
Guard vs undefined EnableTerminationProtection
rscottbailey Oct 28, 2022
12f554e
Defend vs NotificationARNs
rscottbailey Oct 28, 2022
7ca0500
Add check for redirect to HTTPS
x4v13r64 Nov 15, 2022
0f2b48e
Include services when failure
x4v13r64 Nov 15, 2022
4892251
Enhancement/S3-TlsVersion
twilson-bf Nov 28, 2022
92cda50
Improve check
x4v13r64 Dec 12, 2022
65cac92
Fix finding logic
x4v13r64 Dec 12, 2022
9349d03
Update main workflow
michyweb Jan 3, 2023
0a2534d
workflow test
michyweb Jan 3, 2023
afee500
update main workflow
michyweb Jan 3, 2023
3a4acf2
fix throttling test
michyweb Jan 3, 2023
eb57832
Merge pull request #1492 from michyweb/master
michyweb Jan 3, 2023
8749775
Merge pull request #1487 from nccgroup/bugfix/gke-findings
michyweb Jan 3, 2023
205d996
Merge pull request #1482 from nccgroup/enhancement/include-on-fail
michyweb Jan 3, 2023
cbc48e7
Merge pull request #1481 from nccgroup/enhancement/check-elbv2-redirects
michyweb Jan 3, 2023
ded64a9
Merge pull request #1476 from nccgroup/enhancement/catch-1-6
michyweb Jan 3, 2023
963cb91
Merge pull request #1477 from nccgroup/enhancement/public-access-prev…
michyweb Jan 3, 2023
795fc59
Merge pull request #1475 from nccgroup/enhancement/catch_task_exceptions
michyweb Jan 3, 2023
185f1d5
Merge pull request #1474 from nccgroup/enhancement/gcp-lb-support
michyweb Jan 3, 2023
d9708d3
Merge pull request #1464 from elimisteve/patch-1
michyweb Jan 3, 2023
efb7b5a
Merge pull request #1485 from twilson-bf/Enhancement/S3-TlsVersion
michyweb Jan 3, 2023
23ec346
Merge pull request #1479 from rbailey-godaddy/bugfix/aws-cloudformati…
michyweb Jan 3, 2023
72ce1b5
Handle storage profiles without img ref
fernando-gallego Jan 16, 2023
6475f25
Update functions_v1.py
fernando-gallego Jan 16, 2023
ffcf1a9
Update functions_v1.py
fernando-gallego Jan 16, 2023
a4f1722
Update azure-mgmt-authorization
zachfey Mar 2, 2023
ba1b21e
add dashboard_name to rule
wrightmalone Mar 9, 2023
8f93753
Changing regex to comply with python3.11
fl0mb Mar 13, 2023
8cd0f3b
Make test case insensitive
x4v13r64 Mar 23, 2023
e5a30c7
Add case insensitive conditions
x4v13r64 Mar 23, 2023
3f456a7
Include case insensitive checks
x4v13r64 Mar 23, 2023
77388ef
Include case insensitive checks and add conditions
x4v13r64 Mar 23, 2023
b9261c8
Don't swallow unexpected exceptions
ncc-akis Mar 30, 2023
8ae2a0a
GCP credential expiry check
ncc-akis Mar 31, 2023
7d8d81f
Merge pull request #1520 from ncc-akis/bugfix/handle_gcp_api_errors
fernando-gallego Mar 31, 2023
b75d315
fix(gcp): sql-component api is deprecated
saez0pub Apr 5, 2023
6cd1de5
fix(gcp): gke cluster subnetwork can be cross project
saez0pub Apr 5, 2023
6584afb
fix(gcp): False positive on pubsup only cloud functions
saez0pub Apr 5, 2023
b1d9602
fix(gcp): None as cloudfunctions environment_variables
saez0pub Apr 5, 2023
b5d0b6c
Remove credentials validity checks which cause issues
HIKster Apr 6, 2023
d18a9c7
Fix JSON formatting of policies
liyun-li Apr 11, 2023
0548ff1
fix case insensitive conditional
cckev Apr 18, 2023
f495d9e
formatting
cckev Apr 18, 2023
a236eb8
Merge pull request #1524 from liyun-li/fix-json
liyun-li May 5, 2023
e730a50
Merge pull request #1510 from fl0mb/bugfix/1480-python3.11-regex-change
fernando-gallego May 15, 2023
db7890f
Update regexp for Python 3.11
fernando-gallego May 15, 2023
18f0cee
Better API failsafe
liyun-li May 18, 2023
d6a0601
Merge branch 'nccgroup:develop' into develop
liyun-li May 18, 2023
0ef92cf
Merge pull request #1535 from liyun-li/develop
liyun-li May 18, 2023
4bdc430
Merge branch 'develop' into bugfix/s3-policy-key-name-case-sensitive
cckev May 19, 2023
764ad94
directly writing strings in lowercase
cckev May 19, 2023
86d5961
Merge pull request #1467 from rbailey-godaddy/bugfix/smtp-double-jeop…
liyun-li May 19, 2023
06bc502
fix issue #1537
michyweb May 24, 2023
b775a41
Adding coverage in python 3.11 to the CI Workflow
michyweb May 24, 2023
6549177
Merge branch 'develop' into bugfix/s3-policy-key-name-case-sensitive
cckev May 25, 2023
dc75b2e
remove key_map
cckev May 25, 2023
6ee3eaf
Merge pull request #1526 from cckev/bugfix/s3-policy-key-name-case-se…
michyweb May 26, 2023
27d208e
Merge pull request #1523 from HIKster/develop
fernando-gallego May 29, 2023
73459b6
Merge pull request #1506 from wrightmalone/bugfix/1505-failed-to-proc…
fernando-gallego May 29, 2023
fc23d9d
Merge pull request #1504 from zachfey/bugfix/1503-fix-az-aad-fetch-ad…
fernando-gallego May 29, 2023
d6cf479
Update __main__.py
fernando-gallego May 30, 2023
91d5280
Update finding
x4v13r64 Jun 1, 2023
18b6d6a
Logical order
x4v13r64 Jun 1, 2023
acf7bda
Merge pull request #1522 from saez0pub/fix/gcp_audit
liyun-li Jun 5, 2023
36d8bd9
Update __init__.py
michyweb Jun 6, 2023
40d699c
Update setup.py
fernando-gallego Jun 13, 2023
0798a3a
Update testing.yml
fernando-gallego Jun 14, 2023
3d3fa71
Update setup.py
fernando-gallego Jun 14, 2023
7619c30
Ensure correct SQL DB AD Admin check
ncc-akis Jun 27, 2023
44d9851
Quoted Python version numbers
ncc-akis Jun 28, 2023
7543cd7
Use Azure ADE status to prevent false positives
ncc-akis Jun 28, 2023
477a82b
Fix errors in "Key Vault Not Recoverable" rule
ncc-akis Jun 28, 2023
da6b28b
New rule: Azure Key Vault RBAC Disabled
ncc-akis Jun 28, 2023
baedf24
Stop hideAll selector affecting non-list elements
ncc-akis Jun 29, 2023
98e514e
Highlight non-compliant LB ports
ncc-akis Jun 29, 2023
0ef4154
Special case no longer needed
ncc-akis Jun 29, 2023
791f3cc
Evaluate purge protection as bool
ncc-akis Jun 29, 2023
cef3a70
Fix errors in "Key Vault Not Recoverable" rule
ncc-akis Jun 28, 2023
334fafa
New rule: Azure Key Vault Public Access
ncc-akis Jun 29, 2023
cb7299d
Merge pull request #1548 from ncc-akis/bugfix/lb_exceptions
michyweb Jun 29, 2023
afecedf
Merge pull request #1545 from ncc-akis/bugfix/fix_sqldb_ad_admin_asse…
fernando-gallego Jun 30, 2023
242458a
Merge pull request #1546 from ncc-akis/bugfix/workflow_python_version…
fernando-gallego Jun 30, 2023
7125290
Merge pull request #1547 from ncc-akis/feature/evaluate_ade_status
fernando-gallego Jun 30, 2023
219c9a5
Merge pull request #1538 from nccgroup/issues-1529
fernando-gallego Jun 30, 2023
00ab346
Merge pull request #1549 from ncc-akis/bugfix/false_negative_keyvault…
fernando-gallego Jul 3, 2023
e2f0274
Correct dashboard names and compliance references
ncc-akis Jul 3, 2023
d083f92
Merge branch 'develop' into feature/az_keyvault_new_rules
ncc-akis Jul 3, 2023
592505e
Update vaults.py
fernando-gallego Jul 3, 2023
3caf861
Merge pull request #1552 from ncc-akis/feature/az_keyvault_new_rules
fernando-gallego Jul 3, 2023
643acd0
Update __init__.py
fernando-gallego Jul 3, 2023
0c90ab9
Update __init__.py
fernando-gallego Jul 5, 2023
91d90e3
Merge pull request #1555 from nccgroup/develop
fernando-gallego Jul 5, 2023
967ec54
Update README.md
fernando-gallego Sep 22, 2023
ff47599
Merge branch 'master' into enhancement/docker-update
Oct 16, 2023
b3e33df
updated for 5.13
Oct 16, 2023
2ffe244
changed to python 3.12
Oct 16, 2023
7468072
added a combined build to put all the tools into a single container
Oct 16, 2023
f165e94
added combined env
Oct 16, 2023
4a9c2b7
Update route53-domain-transferlock-not-authorized.json
launchdaemon Nov 8, 2023
8c1ee62
Fixed incompatible packages - Update requirements.txt
Tim-Hoekstra Nov 30, 2023
cd9b789
Rule to check if EBS default encryption is enabled.
rdegraaf-ncc3 Jan 20, 2024
524b807
EBS default encryption rule: now highlights the setting in HTML.
rdegraaf-ncc3 Jan 22, 2024
54147a0
added-digitalocean-support
asifwani Feb 4, 2024
63b1b40
added-pagination-support
asifwani Feb 9, 2024
f7350ba
Fixes 'Key Vault Not Recoverable' check
rieck-srlabs Jan 8, 2024
137228e
Fixes 'Key Vault Role Based Access Control Disabled' check
rieck-srlabs Jan 9, 2024
e011d48
Corrected display name for 'Blob Containers Allowing Public Access'
rieck-srlabs Jan 9, 2024
22c5bf6
Improves 'Access Keys Not Rotated' check
rieck-srlabs Jan 10, 2024
631cd70
Merge pull request #1610 from rieck-srlabs/bugfix/1606-fix-keyvault-n…
fernando-gallego Feb 29, 2024
d7485d2
AWS EBS default encryption: fixed display problems.
rdegraaf-ncc3 Mar 4, 2024
f90bcd0
AWS EBS default encryption: renamed files for consistency.
rdegraaf-ncc3 Mar 5, 2024
01de9d0
AWS EBS default encryption: added tests.
rdegraaf-ncc3 Mar 5, 2024
d640d66
AWS EBS default encryption: enabled the single region template.
rdegraaf-ncc3 Mar 5, 2024
68e9199
AWS EBS default encryption: moved parsing logic out of the facade.
rdegraaf-ncc3 Mar 5, 2024
7a6e3c7
Merge pull request #1614 from rdegraaf/feature/1584-aws-ebs-encryption
fernando-gallego Mar 7, 2024
e500930
Updates credential report to not highlight inactive credentials
rieck-srlabs Apr 12, 2024
6bd204a
Improves iam-user-no-key-rotation rule
rieck-srlabs Apr 16, 2024
869919c
Adds highlighting for "EBS Volume Not Encrypted" detail view
rieck-srlabs Apr 17, 2024
f06df79
Digital Ocean Integration
ltoroncc May 7, 2024
b334dd5
Merge pull request #1604 from asifwani/feature/digitalocean-cloud-sup…
fernando-gallego May 7, 2024
29e8063
Merge branch 'develop' into master
fernando-gallego May 7, 2024
2f91ee6
Merge pull request #1632 from ltoroncc/master
fernando-gallego May 7, 2024
373fc14
Merge pull request #1589 from Tim-Hoekstra/master
fernando-gallego May 8, 2024
4ff22f3
Revert "Fixed incompatible packages - Update requirements.txt"
fernando-gallego May 8, 2024
8dbdf2f
Update requirements.txt
fernando-gallego May 8, 2024
7feb470
Merge pull request #1633 from nccgroup/revert-1589-master
fernando-gallego May 8, 2024
6bd80c6
Merge pull request #1586 from launchdaemon/bugfix/route53-domain-lock…
fernando-gallego May 8, 2024
8694556
Update requirements.txt
fernando-gallego May 8, 2024
3654d54
Update requirements.txt
fernando-gallego May 8, 2024
e89be59
Merge pull request #1611 from rieck-srlabs/bugfix/1607-fix-keyvault-r…
fernando-gallego May 8, 2024
cba4cc0
Merge pull request #1612 from rieck-srlabs/bugfix/1608-improve-blob-c…
fernando-gallego May 8, 2024
902bf36
Merge pull request #1613 from rieck-srlabs/bugfix/1609-ignore-storage…
fernando-gallego May 8, 2024
c1434c2
Merge pull request #1623 from rieck-srlabs/bugfix/1621-improve-aws-un…
fernando-gallego May 8, 2024
0a31ecc
Merge pull request #1627 from rieck-srlabs/bugfix/1626-improve-aws-ke…
fernando-gallego May 8, 2024
6df2cfa
Merge pull request #1629 from rieck-srlabs/feature/1628-ebs-volume-de…
fernando-gallego May 8, 2024
de1b62c
Merge pull request #1582 from rossja/master
fernando-gallego May 8, 2024
891c337
Merge pull request #1515 from nccgroup/case-insensitive-conditionals
fernando-gallego May 9, 2024
4194142
Update __init__.py
fernando-gallego May 10, 2024
7909f2f
Merge pull request #1635 from nccgroup/develop
fernando-gallego May 10, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
  •  
  •  
  •  
12 changes: 6 additions & 6 deletions .coveragerc
Original file line number Diff line number Diff line change
Expand Up @@ -3,11 +3,11 @@ include = ScoutSuite/*.py
ScoutSuite/core/*.py
ScoutSuite/output/*.py
ScoutSuite/providers/aws/*.py
ScoutSuite/providers/aws/configs/*.py
ScoutSuite/providers/aws/services/*.py
ScoutSuite/providers/aws/facade/*.py
ScoutSuite/providers/aws/resources/*.py
ScoutSuite/providers/azure/*.py
ScoutSuite/providers/azure/configs/*.py
ScoutSuite/providers/azure/services/*.py
ScoutSuite/providers/azure/facade/*.py
ScoutSuite/providers/azure/resources/*.py
ScoutSuite/providers/gcp/*.py
ScoutSuite/providers/gcp/configs/*.py
ScoutSuite/providers/gcp/services/*.py
ScoutSuite/providers/gcp/facade/*.py
ScoutSuite/providers/gcp/resources/*.py
2 changes: 2 additions & 0 deletions .github/PULL_REQUEST_TEMPLATE.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,8 @@

**Make sure the PR is against the `develop` branch (see [Contributing](https://github.com/nccgroup/ScoutSuite/blob/master/CONTRIBUTING.md)).**

**Make sure to set the corresponding milestone in the PR.**

Please include a summary of the change(s) and which issue(s) it addresses. Please also include relevant motivation and context.

Fixes # (issue)
Expand Down
15 changes: 15 additions & 0 deletions .github/workflows/frontend-build.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,15 @@
name: Fronted Build CI (dummy version)

on:
# Triggers the workflow on push or pull request events but only for the master branch
push:
branches: [ v6-master ]

jobs:
test:
runs-on: ubuntu-18.04
steps:
- name: Show environment v1
run: env | grep ^GITHUB
- name: Show ref v1
run: echo "===============> Version from $GITHUB_REF"
10 changes: 5 additions & 5 deletions .github/workflows/testing.yml
Original file line number Diff line number Diff line change
Expand Up @@ -11,15 +11,15 @@ on:
jobs:
build:

runs-on: ubuntu-latest
runs-on: ubuntu-20.04
strategy:
matrix:
python-version: [3.6, 3.7, 3.8]
python-version: ['3.9', '3.10', '3.11']

steps:
- uses: actions/checkout@v2
- uses: actions/checkout@v3
- name: Set up Python ${{ matrix.python-version }}
uses: actions/setup-python@v2
uses: actions/setup-python@v4
with:
python-version: ${{ matrix.python-version }}
- name: Cache pip
Expand Down Expand Up @@ -52,4 +52,4 @@ jobs:
- name: Upload coverage to Codecov
uses: codecov/codecov-action@v1
with:
file: ./coverage.xml
file: ./coverage.xml
8 changes: 7 additions & 1 deletion .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -51,8 +51,9 @@ inc-scoutsuite-run*
report-*
*.db

# PyCharm
# IntelliJ files
.idea/
*.iml

# Vs Code
.vscode/
Expand All @@ -68,3 +69,8 @@ report-*
# Private folders
/private*/
/**/private*/

#Profiling output
*.prof

!docker/bin
9 changes: 0 additions & 9 deletions Dockerfile

This file was deleted.

2 changes: 2 additions & 0 deletions MANIFEST.in
Original file line number Diff line number Diff line change
Expand Up @@ -13,3 +13,5 @@ recursive-include ScoutSuite/providers/aliyun *
recursive-include ScoutSuite/providers/aliyun/rules *
recursive-include ScoutSuite/providers/oci *
recursive-include ScoutSuite/providers/oci/rules *
recursive-include ScoutSuite/providers/kubernetes *
recursive-include ScoutSuite/providers/kubernetes/rules *
11 changes: 8 additions & 3 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,12 +4,13 @@

#

[![Travis](https://travis-ci.org/nccgroup/ScoutSuite.svg?branch=master)](https://travis-ci.org/nccgroup/ScoutSuite)
[![Coverage Status](https://coveralls.io/repos/github/nccgroup/ScoutSuite/badge.svg?branch=master)](https://coveralls.io/github/nccgroup/ScoutSuite?branch=master)
[![Workflow](https://github.com/nccgroup/ScoutSuite/workflows/CI%20Workflow/badge.svg)](https://github.com/nccgroup/ScoutSuite/actions)
[![CodeCov](https://codecov.io/gh/nccgroup/ScoutSuite/branch/master/graph/badge.svg)](https://codecov.io/gh/nccgroup/ScoutSuite)
[![Total alerts](https://img.shields.io/lgtm/alerts/g/nccgroup/ScoutSuite.svg?logo=lgtm&logoWidth=18)](https://lgtm.com/projects/g/nccgroup/ScoutSuite/alerts/)

[![PyPI version](https://badge.fury.io/py/ScoutSuite.svg)](https://badge.fury.io/py/ScoutSuite)
[![PyPI downloads](https://img.shields.io/pypi/dm/scoutsuite)](https://img.shields.io/pypi/dm/scoutsuite)
[![Docker Hub](https://img.shields.io/badge/Docker%20Hub-rossja%2Fncc--scoutsuite-blue)](https://hub.docker.com/r/rossja/ncc-scoutsuite/)
[![Docker Pulls](https://img.shields.io/docker/pulls/rossja/ncc-scoutsuite.svg?style=flat-square)](https://hub.docker.com/r/rossja/ncc-scoutsuite/)

## Description

Expand All @@ -28,6 +29,8 @@ The following cloud providers are currently supported:
- Google Cloud Platform
- Alibaba Cloud (alpha)
- Oracle Cloud Infrastructure (alpha)
- Kubernetes clusters on a cloud provider (alpha)
- DigitalOcean Cloud (alpha)

## Installation

Expand All @@ -47,3 +50,5 @@ The above report was generated by running Scout Suite against https://github.com

Additional information can be found in the [wiki](https://github.com/nccgroup/ScoutSuite/wiki).
There are also a number of handy [tools](https://github.com/nccgroup/ScoutSuite/tree/master/tools) for automation of common tasks.


2 changes: 1 addition & 1 deletion ScoutSuite/__init__.py
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
__author__ = 'NCC Group'
__version__ = '5.9.1'
__version__ = '5.14.0'

ERRORS_LIST = []

Expand Down
70 changes: 61 additions & 9 deletions ScoutSuite/__main__.py
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
import asyncio
import copy
import os
import webbrowser

Expand All @@ -18,6 +17,9 @@
from ScoutSuite.output.utils import get_filename
from ScoutSuite.providers import get_provider
from ScoutSuite.providers.base.authentication_strategy_factory import get_authentication_strategy
# Dirty workaround for compatibility with Python >= 3.10
import collections
collections.Callable = collections.abc.Callable


def run_from_cli():
Expand Down Expand Up @@ -53,6 +55,16 @@ def run_from_cli():
organization_id=args.get('organization_id'), all_projects=args.get('all_projects'),
# Aliyun
access_key_id=args.get('access_key_id'), access_key_secret=args.get('access_key_secret'),
# Kubernetes
kubernetes_cluster_provider=args.get('kubernetes_cluster_provider'),
kubernetes_config_file=args.get('kubernetes_config_file'),
kubernetes_context=args.get('kubernetes_context'),
kubernetes_persist_config=args.get('kubernetes_persist_config'),
kubernetes_azure_subscription_id=args.get('kubernetes_azure_subscription_id'),
#DigitalOcean
token=args.get('token'),
access_key=args.get('access_key'),
access_secret=args.get('access_secret'),
# General
report_name=args.get('report_name'), report_dir=args.get('report_dir'),
timestamp=args.get('timestamp'),
Expand Down Expand Up @@ -99,6 +111,16 @@ def run(provider,
project_id=None, folder_id=None, organization_id=None, all_projects=False,
# Aliyun
access_key_id=None, access_key_secret=None,
# Kubernetes
kubernetes_cluster_provider=None,
kubernetes_config_file=None,
kubernetes_context=None,
kubernetes_persist_config=True,
kubernetes_azure_subscription_id=None,
#DigitalOcean
token=None,
access_key=None,
access_secret=None,
# General
report_name=None, report_dir=None,
timestamp=False,
Expand Down Expand Up @@ -151,6 +173,16 @@ async def _run(provider,
project_id, folder_id, organization_id, all_projects,
# Aliyun
access_key_id, access_key_secret,
# Kubernetes
kubernetes_cluster_provider,
kubernetes_config_file,
kubernetes_context,
kubernetes_persist_config,
kubernetes_azure_subscription_id,
#DigitalOcean
token,
access_key,
access_secret,
# General
report_name, report_dir,
timestamp,
Expand Down Expand Up @@ -199,12 +231,25 @@ async def _run(provider,
username=username,
password=password,
access_key_id=access_key_id,
access_key_secret=access_key_secret)
access_key_secret=access_key_secret,

#DigitalOcean
token=token,
access_key=access_key,
access_secret=access_secret,

# Kubernetes
kubernetes_cluster_provider=kubernetes_cluster_provider,
kubernetes_config_file=kubernetes_config_file,
kubernetes_context=kubernetes_context,
kubernetes_persist_config=kubernetes_persist_config,
kubernetes_azure_subscription_id=kubernetes_azure_subscription_id,
kubernetes_fetch_local=fetch_local)

if not credentials:
return 101
except Exception as e:
print_exception('Authentication failure: {}'.format(e))
print_exception(f'Authentication failure: {e}')
return 101

# Create a cloud provider object
Expand All @@ -220,6 +265,10 @@ async def _run(provider,
folder_id=folder_id,
organization_id=organization_id,
all_projects=all_projects,
# Kubernetes
kubernetes_config_file=kubernetes_config_file,
kubernetes_context=kubernetes_context,
kubernetes_cluster_provider=kubernetes_cluster_provider,
# Other
report_dir=report_dir,
timestamp=timestamp,
Expand All @@ -228,7 +277,7 @@ async def _run(provider,
programmatic_execution=programmatic_execution,
credentials=credentials)
except Exception as e:
print_exception('Initialization failure: {}'.format(e))
print_exception(f'Initialization failure: {e}')
return 102

# Create a new report
Expand Down Expand Up @@ -273,11 +322,14 @@ async def _run(provider,
if update:
try:
print_info('Updating existing data')
current_run_services = copy.deepcopy(cloud_provider.services)
#Load previous results
last_run_dict = report.encoder.load_from_file('RESULTS')
cloud_provider.services = last_run_dict['services']
for service in cloud_provider.service_list:
cloud_provider.services[service] = current_run_services[service]
#Get list of previous services which were not updated during this run
previous_services = [prev_service for prev_service in last_run_dict['service_list'] if prev_service not in cloud_provider.service_list]
#Add previous services
for service in previous_services:
cloud_provider.service_list.append(service)
cloud_provider.services[service] = last_run_dict['services'][service]
except Exception as e:
print_exception('Failure while updating report: {}'.format(e))

Expand Down Expand Up @@ -336,7 +388,7 @@ async def _run(provider,
exceptions.process(cloud_provider)
exceptions = exceptions.exceptions
except Exception as e:
print_exception('Failed to load exceptions: {}'.format(e))
print_exception(f'Failed to load exceptions: {e}')
exceptions = {}
else:
exceptions = {}
Expand Down
Loading