Remove unnecessary child FSM creation by only instantiating upon transitions #155
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the second issue that I mentioned in #154; it ensures that new child FSMs are only instantiated when transitioning to a new child-containing state, not when eg.
handle
ing a command that's received by a child.As before, I've created a bugcase to demonstrate it, including an example of the erroneous results: https://git.cryto.net/joepie91/machina-factory-bugcase/src/child-switch
Of note:
lib/
in this PR due to merge conflict risks.