fix list sort really

iesahin · Dec 29, 2023 · f0e0acd · f0e0acd
1 parent f97aa7e
commit f0e0acd
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 5 deletions.
diff --git a/book/src/ref/xvc-pipeline-step-list.md b/book/src/ref/xvc-pipeline-step-list.md
@@ -38,8 +38,8 @@ $ xvc pipeline step new --step-name world --command "echo world" --when always
 
 ```console
 $ xvc pipeline step list
-hello: echo hello (by_dependencies)
 world: echo world (always)
+hello: echo hello (by_dependencies)
 
 ```
 

diff --git a/pipeline/src/pipeline/api/step_list.rs b/pipeline/src/pipeline/api/step_list.rs
@@ -16,18 +16,17 @@ pub fn cmd_step_list(
 
     xvc_root
         .with_r1nstore(|rs: &R1NStore<XvcPipeline, XvcStep>| {
-            let steps: HStore<XvcStep> =
-                rs.children_of(&pipeline_e)?.into_iter().sorted().collect();
+            let steps: HStore<XvcStep> = rs.children_of(&pipeline_e)?;
 
             if names_only {
-                for (_, step) in steps {
+                for (_, step) in steps.into_iter().sorted() {
                     output!(output_snd, "{}", step);
                 }
             } else {
                 let bs_command = xvc_root.load_store::<XvcStepCommand>()?;
                 let bs_invalidate = xvc_root.load_store::<XvcStepInvalidate>()?;
 
-                for (step_e, step) in steps {
+                for (step_e, step) in steps.into_iter().sorted() {
                     let command = &bs_command[&step_e];
                     let invalidate = bs_invalidate.get(&step_e).cloned().unwrap_or_default();
                     output!(output_snd, "{}: {} ({})", step, command, invalidate);