This repository has been archived by the owner on May 3, 2023. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
R 4.0.0 is being released soon and
stringsAsFactors = default.stringsAsFactors()
will becomestringsAsFactors = FALSE
and qdap now fails. I have fixed this and am pushing to CRAN soon. I have also moved functions from the reports package into qdap because I plan to archive the reports package. These changes now cause ie2misc to have the following error:I pulled your package and see you import all the functions from qdap rather than just
multigsub
. I have made the following changes to fix this:Changed
#' import qdap
to#' @importFrom qdap multigsub
. This keeps qdap'sdelete
function from overwriting thedelete
from gWidgets2.I still see there are three warnings unrelated to qdap changes:
These fixes ar eprobably as simple as bumping the package version in the DESCRIPTION, removing
ie2miscdata
from suggests b/c it's archived, and fixing or removing the bad URLs.Also, if you want to just grab the relevant code from qdap for
multigsub
and put it into your source files directly and not import qdap feel free. You have my blessing. qdap has a number of dependencies and this would make your package lighter weight.