Skip to content
This repository has been archived by the owner on May 3, 2023. It is now read-only.

Changed for qdap's push to CRAN #2

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

trinker
Copy link

@trinker trinker commented Apr 19, 2020

R 4.0.0 is being released soon and stringsAsFactors = default.stringsAsFactors() will become stringsAsFactors = FALSE and qdap now fails. I have fixed this and am pushing to CRAN soon. I have also moved functions from the reports package into qdap because I plan to archive the reports package. These changes now cause ie2misc to have the following error:

Found the following significant warnings:
     Warning: replacing previous import 'gWidgets2::delete' by 'qdap::delete' when loading 'ie2misc'

I pulled your package and see you import all the functions from qdap rather than just multigsub. I have made the following changes to fix this:

Changed #' import qdap to #' @importFrom qdap multigsub. This keeps qdap's delete function from overwriting the delete from gWidgets2.

I still see there are three warnings unrelated to qdap changes:

  • Insufficient package version (submitted: 0.8.5, existing: 0.8.5)
  • Suggests or Enhances not in mainstream repositories: ie2miscdata
  • A few urls come back as not found 404

These fixes ar eprobably as simple as bumping the package version in the DESCRIPTION, removing ie2miscdata from suggests b/c it's archived, and fixing or removing the bad URLs.

Also, if you want to just grab the relevant code from qdap for multigsub and put it into your source files directly and not import qdap feel free. You have my blessing. qdap has a number of dependencies and this would make your package lighter weight.

…ps qdap's delete function from overwriting the delete from gWidgets2.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant