Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

إضافة صيغة json للمخرجات، إضافة اختيار --version #31

Merged
merged 1 commit into from
Aug 23, 2023
Merged

إضافة صيغة json للمخرجات، إضافة اختيار --version #31

merged 1 commit into from
Aug 23, 2023

Conversation

AliOsm
Copy link
Member

@AliOsm AliOsm commented Aug 23, 2023

No description provided.

@AliOsm AliOsm self-assigned this Aug 23, 2023
@sonarcloud
Copy link

sonarcloud bot commented Aug 23, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

IbraheemTuffaha
IbraheemTuffaha approved these changes Aug 23, 2023
View reviewed changes
Copy link
Collaborator

@IbraheemTuffaha IbraheemTuffaha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!
But first upgrade version to v1.1.0 as this is a minor release (added new functionality)

@AliOsm AliOsm merged commit 08b7b34 into main Aug 23, 2023
3 checks passed
@AliOsm AliOsm deleted the json_output branch August 23, 2023 19:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yshalsager yshalsager yshalsager approved these changes

@IbraheemTuffaha IbraheemTuffaha IbraheemTuffaha approved these changes

Assignees

@AliOsm AliOsm

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AliOsm @yshalsager @IbraheemTuffaha