[ cleanup ] Make makeFuture
to be %foreign
, not %extern
#3341
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
System.Future
incontrib
is strange, especially because it relies on two backend-specific functions,prim__makeFuture
andprim__awaitFuture
which are very different: the first one is a special primitive function that compiler is aware of, when the second one is a normal%foreign
function. The main reason for this was the desire to passLazy
value into the foreign function, which is not supported (for good reason, I think), so it was made a primitive.But I think that this was, basically, the XY-problem -- we actually wanted to pass not a
Lazy
value of typea
, but a function that returnsa
when demanded -- in general case, semantics ofLazy
values may differ, but semantics of this call does not. Also, it is pretty disgusting that we have a compiler primitive that is excersised only incontrib
. Also, this siituation leads to problems like #3292.So, I propose the change which makes both basic functions in this module be declared as
%foreign
, thus removing theMakeFuture
primitive from the compiler.Should this change go in the CHANGELOG?
implementation, I have updated
CHANGELOG_NEXT.md
(and potentially alsoCONTRIBUTORS.md
).